This repository was archived by the owner on Nov 27, 2018. It is now read-only.
Route DataTokens- Readonly #92
Comments
|
IReadOnlyDictionary doesn't really prevent you from changing the content of the datatoken, but I think this is still fine. Moving to beta milestone because this is an API shape we want to try and lock down pre-beta. |
rynowak
added a commit
that referenced
this issue
Nov 11, 2014
The properties on TemplateRoute for DataTokens and Defaults are now readonly. This prevents modifying these collections in a way that invalidates cached data, or violates thread-safety. The next change will do the same for Constraints, which is a more substantial refactor.
rynowak
added a commit
that referenced
this issue
Nov 11, 2014
The properties on TemplateRoute for DataTokens and Defaults are now readonly. This prevents modifying these collections in a way that invalidates cached data, or violates thread-safety. The next change will do the same for Constraints, which is a more substantial refactor.
rynowak
added a commit
that referenced
this issue
Nov 13, 2014
This change is a substantial refactor of how we realize inline constraints, and moves the constraint resolver out of the parsing phase. This allow creates a builder for the constraint map, that will make it easier to implement features like optional constraints, and is reusable for anyone building their own type of routing system.
rynowak
added a commit
that referenced
this issue
Nov 13, 2014
This change is a substantial refactor of how we realize inline constraints, and moves the constraint resolver out of the parsing phase. This allow creates a builder for the constraint map, that will make it easier to implement features like optional constraints, and is reusable for anyone building their own type of routing system.
rynowak
added a commit
that referenced
this issue
Nov 18, 2014
This change is a substantial refactor of how we realize inline constraints, and moves the constraint resolver out of the parsing phase. This allow creates a builder for the constraint map, that will make it easier to implement features like optional constraints, and is reusable for anyone building their own type of routing system.
rynowak
added a commit
that referenced
this issue
Nov 18, 2014
The properties on TemplateRoute for DataTokens and Defaults are now readonly. This prevents modifying these collections in a way that invalidates cached data, or violates thread-safety. To do the same for constraints, this change includes a substantial refactor of how we realize inline constraints, and moves the constraint resolver out of the parsing phase. This allow creates a builder for the constraint map, that will make it easier to implement features like optional constraints, and is reusable for anyone building their own type of routing system.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Lifting the comment from #88
This might allow us to do re-use the Dictionary when the passed in value is null. I'm not familiar with the use case for this, but is it meant to be modifiable by a user?
The text was updated successfully, but these errors were encountered: