This repository was archived by the owner on Nov 27, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 122
Throw a nicer error when the routing services haven't been added to DI #276
Comments
MVC already does this. We can follow the same model. |
Can we not follow the same model instead? It would be nice to do this on Startup instead of on first request |
Hmm ok, do we have an idea of how to do that? |
We can register a marker service and have the routing middleware resolve it when created. |
Ya, the code linked to above does this. |
MVC does it on first request - we should think about changing it to do it when we add AddMvc. |
@javiercn you got that? Let's add this to Routing, and then also change MVC to do the same. I logged aspnet/Mvc#3907 and assigned to you. |
@Eilon will do it for routing and mvc |
javiercn
added a commit
that referenced
this issue
Jan 13, 2016
javiercn
added a commit
that referenced
this issue
Jan 13, 2016
javiercn
added a commit
that referenced
this issue
Jan 14, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Like other parts of the framework we should throw a nice helper exception when services are missing from DI, including the sample call the app needs to add the routing services to DI, e.g.
The text was updated successfully, but these errors were encountered: