Skip to content
This repository was archived by the owner on Feb 23, 2021. It is now read-only.

Move from using IAssemblyLoadContext => AssemblyLoadContext #29

Closed
NTaylorMullen opened this issue Oct 21, 2015 · 3 comments
Closed

Move from using IAssemblyLoadContext => AssemblyLoadContext #29

NTaylorMullen opened this issue Oct 21, 2015 · 3 comments
Assignees
@NTaylorMullen
Labels
3 - Done enhancement
Milestone
1.0.0-preview1

Comments

@NTaylorMullen
Copy link
Contributor

We're moving Razor assembly loading from IAssemblyLoadContext => AssemblyLoadContext in MVC. We need to also accomplish this in this repo to ensure TagHelperDescriptor assemblies continue to load.

@muratg
@NTaylorMullen NTaylorMullen self-assigned this Oct 21, 2015
@NTaylorMullen NTaylorMullen added this to the 1.0.0-rc1 milestone Oct 21, 2015
@muratg
Copy link

muratg commented Oct 21, 2015

👍

@NTaylorMullen
Copy link
Contributor Author

Talked with @davidfowl and this wont be able to make it into RC1 and work. Need to punt this to RC2.

@muratg muratg modified the milestones: 1.0.0-rc2, 1.0.0-rc1 Oct 21, 2015
@NTaylorMullen NTaylorMullen mentioned this issue Dec 9, 2015
Merged
NTaylorMullen added a commit that referenced this issue Dec 14, 2015
@NTaylorMullen
Remove dependency on IAssemblyLoadContext.
50e9e36 
- Transitioned to `AssemblyLoadContext`. Was able to remove a few dependencies from `project.json` but also had to rev the dotnet version to 5.5.

#29
@NTaylorMullen NTaylorMullen mentioned this issue Dec 14, 2015
Merged
NTaylorMullen added a commit that referenced this issue Dec 17, 2015
@NTaylorMullen
Remove dependency on IAssemblyLoadContext.
3de479b 
- Transitioned to `Assembly.Load`.

#29
@NTaylorMullen
Copy link
Contributor Author

3de479b

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NTaylorMullen NTaylorMullen

Labels
3 - Done enhancement
Projects
None yet
Milestone
1.0.0-preview1
Development

No branches or pull requests
2 participants
@muratg @NTaylorMullen