This repository was archived by the owner on Dec 19, 2018. It is now read-only.
Modify parser to group html begin/end elements. #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Output(SpanKind.Markup); | ||
|
|
||
| IDisposable tagBlock = null; | ||
| // Do not want to start a new tag block if we're at the end of the file. |
There was a problem hiding this comment.
nit: move this comment up one line since it helps to understand the null initialization
|
Addressed comments and updated PR |
| PutBack(openAngle); // Put back '<' | ||
| } | ||
|
|
||
| if(seenEndScript) |
|
|
after addressing my few recently-added issues
This was referenced Aug 25, 2014
| Output(SpanKind.Markup); | ||
|
|
||
| // Will be null if we were at end of file or special tag when initially created. | ||
| if (tagBlockWrapper != null) |
There was a problem hiding this comment.
try/finally for IDisposable?
NTaylorMullen
force-pushed
the
TagHelpers_TagBlockParsing
branch
from
23dada9 to
2eb7591
Compare
|
Addressed comments for all except for the one q: #86 (comment) |
| @@ -176,7 +176,7 @@ private HtmlSymbol Whitespace() | |||
| private HtmlSymbol Newline() | |||
| { | |||
| Debug.Assert(ParserHelpers.IsNewLine(CurrentCharacter)); | |||
| // CSharp Spec §2.3.1 | |||
| // CSharp Spec §2.3.1 | |||
There was a problem hiding this comment.
surface "typo" comment I made on a commit.
- Added a "Tag" block type. - Wrapped all begin/end elements in a "Tag" Markup block. #75
|
Will push this in once the test PR is complete. |
NTaylorMullen
force-pushed
the
TagHelpers_TagBlockParsing
branch
from
6992d12 to
6114d5d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tag Helpers: Modify parser to create begin/end html tag elements that are ungrouped. #75
Since this impacted a large amount of the existing tests I've created a separate "test" PR. I felt that the existing tests did more than enough verification for this "feature" since it's at the core of the Razor parser, let me know if you have a different opinion.
Test PR: #87