This repository was archived by the owner on Dec 19, 2018. It is now read-only.
Remove ~/ handling from core Razor. #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @dougbu @ajaybhargavb |
|
This test |
| @@ -136,8 +136,6 @@ public struct GeneratedClassContext | |||
| public string WriteAttributeMethodName { get; set; } | |||
| public string WriteAttributeToMethodName { get; set; } | |||
|
|
|||
| [SuppressMessage("Microsoft.Design", "CA1056:UriPropertiesShouldNotBeStrings", Justification = "Property is not a URL property")] | |||
| public string ResolveUrlMethodName { get; set; } | |||
|
|
|||
|
|
| @@ -122,30 +122,6 @@ public void MultiValueExpressionAttribute() | |||
| } | |||
|
|
|||
| [Fact] | |||
| public void VirtualPathAttributesWorkWithConditionalAttributes() | |||
| { | |||
| ParseBlockTest("<a href='@foo ~/Foo/Bar' />", | |||
There was a problem hiding this comment.
Would prefer we keep one of these, showing the straightforward set of Spans and Blocks generated. Helps to show ~ remains not special at this level.
|
|
- Removed parsing, chunk generation and code generation. - Removed related tests. - Did not modify existing unrelated tests with ~/ since it's just plain text and may be valid for end-users. #427
NTaylorMullen
force-pushed
the
nimullen/apprelativeurls.427
branch
from
39ec988 to
48a6b56
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
~/handling from core Razor. #427MVC PR to add app-relative URL resolution: aspnet/Mvc#2875