This repository was archived by the owner on Dec 19, 2018. It is now read-only.
Update Razor SDK packing logic to not include Pack at properties layer. #2420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NTaylorMullen
force-pushed
the
nimullen/2384
branch
from
586eac5 to
acc4562
Compare
pranavkm
reviewed
Jun 21, 2018
| @@ -15,6 +15,46 @@ public PackIntegrationTest(BuildServerTestFixture buildServer) | |||
| { | |||
| } | |||
|
|
|||
| [Fact] | |||
| [InitializeTestProject("ClassLibrary")] | |||
| public async Task Pack__NoBuild_Works_IncludesRazorAssembly() | |||
There was a problem hiding this comment.
nit: two underscores after Pack
There was a problem hiding this comment.
Could you also add a test that verifies we do add the files in no-build scenarios if the flag is set?
NTaylorMullen
commented
Jun 21, 2018
| Assert.NuspecContains( | ||
| result, | ||
| Path.Combine("obj", Configuration, "ClassLibrary.1.0.0.nuspec"), | ||
| @"<files include=""any/netstandard2.0/Views/Shared/_Layout.cshtml"" buildAction=""Content"" />"); |
There was a problem hiding this comment.
I'm assuming this will fail on travis but we'll see.
|
🆙 📅 |
pranavkm
approved these changes
Jun 21, 2018
NTaylorMullen
force-pushed
the
nimullen/2384
branch
2 times, most recently
from
0ec2172 to
5139c82
Compare
- Added test to verify that no-build scenarios work as expected. #2378
- Also fixed wording of existing nobuild test.
NTaylorMullen
force-pushed
the
nimullen/2384
branch
from
5139c82 to
34ebc0f
Compare
|
@NTaylorMullen this should be good to go in now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2378
#2384
@mkArtakMSFT This is ready to go, let me know when i'm good to merge.