This repository was archived by the owner on Dec 19, 2018. It is now read-only.
Add ContentBehaviorAttribute for TagHelpers. #166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var typeInfo = type.GetTypeInfo(); | ||
| var contentBehaviorAttribute = typeInfo.GetCustomAttribute<ContentBehaviorAttribute>(inherit: false); | ||
|
|
||
| return contentBehaviorAttribute?.ContentBehavior ?? DefaultContentBehavior; |
NTaylorMullen
force-pushed
the
TagHelpers_ScopeManager
branch
from
b7749f9 to
5b5111a
Compare
NTaylorMullen
force-pushed
the
TagHelpers_ContentBehavior
branch
from
8f15a16 to
78a61d8
Compare
NTaylorMullen
force-pushed
the
TagHelpers_ScopeManager
branch
from
5b5111a to
03115f9
Compare
NTaylorMullen
force-pushed
the
TagHelpers_ContentBehavior
branch
from
78a61d8 to
7565cd6
Compare
NTaylorMullen
force-pushed
the
TagHelpers_ScopeManager
branch
from
03115f9 to
c39c360
Compare
NTaylorMullen
force-pushed
the
TagHelpers_ContentBehavior
branch
from
7565cd6 to
d3b481a
Compare
NTaylorMullen
force-pushed
the
TagHelpers_ScopeManager
branch
from
c39c360 to
41e44b3
Compare
NTaylorMullen
force-pushed
the
TagHelpers_ContentBehavior
branch
from
d3b481a to
55b4148
Compare
NTaylorMullen
force-pushed
the
TagHelpers_ScopeManager
branch
from
41e44b3 to
cabe3dc
Compare
NTaylorMullen
force-pushed
the
TagHelpers_ContentBehavior
branch
from
55b4148 to
20762a7
Compare
NTaylorMullen
force-pushed
the
TagHelpers_ScopeManager
branch
from
cabe3dc to
3e18f61
Compare
NTaylorMullen
force-pushed
the
TagHelpers_ContentBehavior
branch
from
20762a7 to
ba8c7eb
Compare
NTaylorMullen
force-pushed
the
TagHelpers_ScopeManager
branch
from
3e18f61 to
42556ce
Compare
NTaylorMullen
force-pushed
the
TagHelpers_ContentBehavior
branch
from
ba8c7eb to
2e8616f
Compare
NTaylorMullen
force-pushed
the
TagHelpers_ScopeManager
branch
from
42556ce to
09e5719
Compare
NTaylorMullen
force-pushed
the
TagHelpers_ContentBehavior
branch
from
2e8616f to
7501edc
Compare
NTaylorMullen
force-pushed
the
TagHelpers_ScopeManager
branch
from
09e5719 to
294fa36
Compare
NTaylorMullen
force-pushed
the
TagHelpers_ContentBehavior
branch
from
7501edc to
738104f
Compare
NTaylorMullen
force-pushed
the
TagHelpers_ScopeManager
branch
from
294fa36 to
0a5b27f
Compare
NTaylorMullen
force-pushed
the
TagHelpers_ContentBehavior
branch
from
738104f to
c08a823
Compare
NTaylorMullen
force-pushed
the
TagHelpers_ScopeManager
branch
from
0a5b27f to
5355a6e
Compare
NTaylorMullen
force-pushed
the
TagHelpers_ContentBehavior
branch
from
c08a823 to
7fef72c
Compare
| namespace Microsoft.AspNet.Razor.Runtime.TagHelpers | ||
| { | ||
| /// <summary> | ||
| /// Used to override <see cref="TagHelper"/>s functionality for when its |
There was a problem hiding this comment.
/// ... a <see cref="TagHelper"/>'s ... (add a word and apostrophe)
There was a problem hiding this comment.
nit: "functionality" isn't used much (and doesn't mean much) and "for" is noise. suggest "behavior" instead of "functionality for".
There was a problem hiding this comment.
... or perhaps just /// Used to override when the <see cref="TagHelper"/>'s ... method is called from generated code. I'm not convinced you need "from generated code" but don't mention TagHelperRunner since that's not visible to most.
| var typeInfo = type.GetTypeInfo(); | ||
| var contentBehaviorAttribute = typeInfo.GetCustomAttribute<ContentBehaviorAttribute>(inherit: false); | ||
|
|
||
| return contentBehaviorAttribute?.ContentBehavior ?? ContentBehavior.None; |
There was a problem hiding this comment.
nit: not sure the compiler is smart enough to skip null-checking the ContentBehavior property. either way, this looks like two null checks rather than the one you need. so a ternary expression is more straightforward.
|
|
after addressing non-nit comments, especially allowing inheritance of the attribute
NTaylorMullen
force-pushed
the
TagHelpers_ScopeManager
branch
from
5355a6e to
9d125d2
Compare
NTaylorMullen
force-pushed
the
TagHelpers_ContentBehavior
branch
from
7fef72c to
38a1f50
Compare
|
Will push this once its dependent PR's have been signed off on. |
NTaylorMullen
force-pushed
the
TagHelpers_ScopeManager
branch
from
9d125d2 to
40e755c
Compare
NTaylorMullen
force-pushed
the
TagHelpers_ContentBehavior
branch
from
38a1f50 to
ed954ef
Compare
| } | ||
|
|
||
| /// <summary> | ||
| /// =<see cref="Razor.TagHelpers.ContentBehavior"/> for the <see cref="ITagHelper"/>. |
|
still |
- Added detection of custom ContentBehaviors via the ContentBehaviorAttribute in the TagHelperDescriptorFactory. - Updated some comments in the ContentBehavior enum. - Add tests to validate custom content behavior resolution. #122
NTaylorMullen
force-pushed
the
TagHelpers_ScopeManager
branch
from
40e755c to
46a7105
Compare
NTaylorMullen
force-pushed
the
TagHelpers_ContentBehavior
branch
from
ed954ef to
4dceae9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tag Helpers: Add ability to specify ContentBehavior #122