This repository was archived by the owner on Dec 19, 2018. It is now read-only.
Re-add marker IR tokens to represent CSharp in an expression. #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4c0afba.
- At design time we weren't generating line mappings when a user would type `@` or `@(`. This results in no C# IntelliSense being provided to the user because the editor hasn't mapped any of Razor to the C# buffer. - Modified the `DefaultIRLoweringPhase` to allow for marker symbols, these symbols . - Re-generated test files to account for 0 length line mappings on empty expression nodes. #1155
ajaybhargavb
approved these changes
Apr 3, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverted the last generate line mapping bits for empty expressions because it wasn't 100% accurate. It wouldn't always generate line mappings in the correct location. Example, if a user wrote
@()they would get a line mapping that would point to the beginning of the@and not in the middle of the parens. I re-enabled IR for empty CSharp tokens since they inherently represent where C# is expected. A great example of this expectation is writing@before would never end up in a C# compile error because we'd strip out theWrite(statement; with markers we get appropriate errors and design time experience.@or@(. This results in no C# IntelliSense being provided to the user because the editor hasn't mapped any of Razor to the C# buffer.DefaultIRLoweringPhaseto allow for marker symbols, these symbols .#1155
This is blocking tooling.