Add TagHelper parse tree rewriter. #109
Conversation
|
|
||
| using System.Collections.Generic; | ||
|
|
||
| namespace Microsoft.AspNet.Razor.Generator.Compiler |
There was a problem hiding this comment.
This namespace will change once this is completed: #39 For now I've made it consistent with the other chunks.
NTaylorMullen
changed the title
| if (NextIs(HtmlSymbolType.ForwardSlash)) | ||
| { | ||
| AcceptAndMoveNext(); | ||
| } |
There was a problem hiding this comment.
this addition looks like an unrelated bug fix. what does it have to do with visiting the parse tree (and rewriting some elements as TagHelperBlocks)?
There was a problem hiding this comment.
Yes, found an issue that I introduced in the HtmlBlock translation where the parser deadlocked in veryy edge case scenarios inside of script tags.
There was a problem hiding this comment.
please send out a separate PR, preferably with tests of the edge case
|
/cc @anurse |
NTaylorMullen
force-pushed
the
TagHelpers_ParseTreeRewriter
branch
from
5b494d1 to
858b88b
Compare
| EditHandler = span.EditHandler, | ||
| Kind = span.Kind | ||
| }; | ||
| var htmlSymbols = ((IEnumerable<HtmlSymbol>)span.Symbols).ToArray(); |
There was a problem hiding this comment.
shouldn't have CSharpSymbol instances in this collection but probably still worth being careful: span.Symbols.OfType<HtmlSymbol>().ToArray()
|
⌚ |
|
Addressed comments. |
| BuildCurrentlyTrackedBlock(); | ||
| } | ||
|
|
||
| private bool IsValidTagHelper(string tagName, Block childBlock) |
There was a problem hiding this comment.
IsPotentialTagHelper
| attributeChildren.Parent = this; | ||
| } | ||
| } | ||
|
|
|
|
after addressing nits and my comments on comments
TagHelpers: Create parse visitors that understand "special" html #71
NOTE: This does not support malformed tag helpers. It expects all tags (that are tag helpers) are validly formed. That fix will come with: #104
Also I opened a separate test PR due to size here: #110
Issue: #71