Skip to content
This repository was archived by the owner on Dec 19, 2018. It is now read-only.

Add errors for multiple tagHelperPrefix directives in the same file #942

Closed
rynowak opened this issue Jan 19, 2017 · 1 comment
Closed
Assignees
Milestone

Comments

@rynowak
Copy link
Member

rynowak commented Jan 19, 2017

Currently Razor will use the (lexical) first @tagHelperPrefix in each file and will report an error for each subsequent one. This allows views to override an imported @tagHelperPrefix but not to specify it multiple times in the same file.

After some discussion, it's likely that this semantic should be applied to more of our directives or at least applied at a different layer than it is today. I'm logging this issue to follow up with implementing this validation since we're temporarily adding support for the taghelper directives without preserving the current behavior.

@Eilon Eilon added the 1 - Ready label Feb 1, 2017
@Eilon Eilon added this to the 2.0.0 milestone Feb 1, 2017
@rynowak rynowak removed the Evolution label Apr 14, 2017
@rynowak rynowak added the bug label May 5, 2017
@rynowak rynowak modified the milestones: 2.0.0-preview2, 2.0.0-preview3 May 30, 2017
NTaylorMullen added a commit that referenced this issue Jun 28, 2017
- Regenerated diagnostics for integration tests.
- Added a duplicate directive unit test.
- Added a new RazorDiagnostic entry in the factory.

#942
NTaylorMullen added a commit that referenced this issue Jun 28, 2017
- Regenerated diagnostics for integration tests.
- Added a duplicate directive unit test.
- Added a new RazorDiagnostic entry in the factory.

#942
NTaylorMullen added a commit that referenced this issue Jun 28, 2017
- Regenerated diagnostics for integration tests.
- Added a duplicate directive unit test.
- Added a new RazorDiagnostic entry in the factory.

#942
@NTaylorMullen
Copy link
Contributor

05cc412

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants