Skip to content
This repository was archived by the owner on Dec 19, 2018. It is now read-only.

Implement Order #94

Closed
NTaylorMullen opened this issue Aug 22, 2014 · 1 comment
Closed

Implement Order #94

NTaylorMullen opened this issue Aug 22, 2014 · 1 comment
Assignees
@NTaylorMullen
Labels
3 - Done enhancement
Milestone
1.0.0-beta4

Comments

@NTaylorMullen
Copy link
Contributor

Right now if you have multiple TagHelpers that target the same tag element they run in pretty much a random order. We should implement an attribute that controls what order Tag Helpers are run in.
@NTaylorMullen NTaylorMullen added this to the 4.0.0-beta1 milestone Aug 22, 2014
@NTaylorMullen NTaylorMullen self-assigned this Aug 22, 2014
@danroth27 danroth27 modified the milestones: 4.0.0-rc1, 4.0.0-beta1 Sep 4, 2014
@yishaigalatzer yishaigalatzer modified the milestones: 4.0.0-rc1, 4.0.0-beta3 Jan 15, 2015
@NTaylorMullen NTaylorMullen changed the title Tag Helper: Implement Order Implement Order Jan 23, 2015
NTaylorMullen added a commit that referenced this issue Jan 26, 2015
@NTaylorMullen
Add order attribute and corresponding TagHelperDescriptor property.
f90c19f 
- Added codegen code to pass appropriate order into the TagHelperExecutionContext. Ultimately decided to make order control a runtime feature to allow flexibility in the future.

#94
NTaylorMullen added a commit that referenced this issue Jan 26, 2015
@NTaylorMullen
Add unit and functional tests for TagHelper order.
7a27c81 
- Added functional code generation tests and unit tests.
- Tested runtime and parse time features of the OrderAttribute.
- Modified existing codegen test to further validate the Order attribute value.

#94
NTaylorMullen added a commit that referenced this issue Jan 26, 2015
@NTaylorMullen
Add order attribute and corresponding TagHelperDescriptor property.
ed1b9bb 
- Added codegen code to pass appropriate order into the TagHelperExecutionContext. Ultimately decided to make order control a runtime feature to allow flexibility in the future.

#94
NTaylorMullen added a commit that referenced this issue Jan 26, 2015
@NTaylorMullen
Add unit and functional tests for TagHelper order.
b8363f0 
- Added functional code generation tests and unit tests.
- Tested runtime and parse time features of the OrderAttribute.
- Modified existing codegen test to further validate the Order attribute value.

#94
@NTaylorMullen NTaylorMullen mentioned this issue Jan 26, 2015
Merged
NTaylorMullen added a commit that referenced this issue Jan 26, 2015
@NTaylorMullen
Add order property to control TagHelper execution order.
23676b1 
- Added order property to the ITagHelper class. Lower values indicates higher execution priority.

#94
NTaylorMullen added a commit that referenced this issue Jan 26, 2015
@NTaylorMullen
Add tests for TagHelper order control.
f03c127 
- Tested runtime run execution order control.

#94
NTaylorMullen added a commit that referenced this issue Jan 26, 2015
@NTaylorMullen
Add tests for TagHelper order control.
cd2c51f 
- Tested runtime run execution order control.

#94
NTaylorMullen added a commit to aspnet/Mvc that referenced this issue Jan 28, 2015
@NTaylorMullen
React to aspnet/Razor#94.
3e3dd02 
- Implemented ITagHelperinterface for TagCloudViewComponentTagHelper in the TagHelperSample.
NTaylorMullen added a commit that referenced this issue Jan 28, 2015
@NTaylorMullen
Add order property to control TagHelper execution order.
53d6015 
- Added order property to the ITagHelper class. Lower values indicates higher execution priority.

#94
NTaylorMullen added a commit that referenced this issue Jan 28, 2015
@NTaylorMullen
Add tests for TagHelper order control.
a0574fb 
- Tested runtime run execution order control.

#94
@NTaylorMullen
Copy link
Contributor Author

53d6015
a0574fb

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NTaylorMullen NTaylorMullen

Labels
3 - Done enhancement
Projects
None yet
Milestone
1.0.0-beta4
Development

No branches or pull requests
3 participants
@yishaigalatzer @danroth27 @NTaylorMullen