Skip to content
This repository was archived by the owner on Dec 19, 2018. It is now read-only.

@addtaghelper and @removetaghelper should allow wild cards. #285

Closed
NTaylorMullen opened this issue Jan 29, 2015 · 1 comment
Closed

@addtaghelper and @removetaghelper should allow wild cards. #285

NTaylorMullen opened this issue Jan 29, 2015 · 1 comment

Comments

@NTaylorMullen
Copy link
Contributor

Currently to add all TagHelpers in an assembly you need to do @addtaghelper "MyAssembly". This should change to be less ambiguous to something like: @addtaghelper "*, MyAssembly". Same goes for @removetaghelper. This way the user is always specifying some sort of type name.

This also means adding support for * in the type name specification for @addtaghelper.

@NTaylorMullen NTaylorMullen self-assigned this Jan 29, 2015
@NTaylorMullen NTaylorMullen added this to the 4.0.0-rc1 milestone Jan 29, 2015
@NTaylorMullen NTaylorMullen changed the title @addtaghelper Should require type name and not just assembly name. @addtaghelper and @removetaghelper should require type names and not just assembly names. Jan 30, 2015
@NTaylorMullen NTaylorMullen changed the title @addtaghelper and @removetaghelper should require type names and not just assembly names. @addtaghelper and @removetaghelper should allow wild cards. Jan 30, 2015
NTaylorMullen added a commit that referenced this issue Jan 30, 2015
- @addtaghelper and @removetaghelper can now utilize the '*' wild card to represent 0 or more characters.
- Restricted the @addtaghelper to need the TypeName. @addtaghelper "MyAssemblyName" => @addtaghelper "*, MyAssemblyName".

#285
NTaylorMullen added a commit that referenced this issue Jan 30, 2015
- Also added tests to ensure cases of @addtaghelper "MyAssemblyName" create an error.
- Regenerated all CS files to folow new format.

#285
NTaylorMullen added a commit that referenced this issue Feb 3, 2015
- @addtaghelper and @removetaghelper can now utilize the '*' wild card to represent 0 or more characters.
- Restricted the @addtaghelper to need the TypeName. @addtaghelper "MyAssemblyName" => @addtaghelper "*, MyAssemblyName".

#285
NTaylorMullen added a commit that referenced this issue Feb 3, 2015
- Also added tests to ensure cases of @addtaghelper "MyAssemblyName" create an error.
- Regenerated all CS files to folow new format.

#285
@NTaylorMullen
Copy link
Contributor Author

a78ed66
32f0858

NTaylorMullen added a commit to aspnet/Mvc that referenced this issue Feb 3, 2015
- Cannot only provide assembly name to @addtaghelper.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant