Skip to content
This repository was archived by the owner on Dec 19, 2018. It is now read-only.

Camel-case tag helper directives #264

Closed
glen-84 opened this issue Dec 28, 2014 · 4 comments
Closed

Camel-case tag helper directives #264

glen-84 opened this issue Dec 28, 2014 · 4 comments

Comments

@glen-84
Copy link

glen-84 commented Dec 28, 2014

When multiple words are joined and the full string is lower-cased (or upper-cased), it makes it difficult to read.

For example:

@addtaghelper X

Would it be possible to make directives case insensitive, or at least allow camel or pascal case?

@addTagHelper X

Unrelated to this ticket: Would it not make sense to use a different prefix for directives, so that they don't look like variables? Something like:

@!model WebApplication1.Models.LoginViewModel

... just a thought.

@danroth27 danroth27 changed the title RFC: Make directives case insensive or allow camel case RFC: Make directives case insensitive or allow camel case Jan 9, 2015
@danroth27
Copy link
Member

We think directives should be case sensitive, but we think we should change addtaghelper to addTagHelper, removetaghelper to removeTagHelper, etc.

@danroth27 danroth27 added this to the 4.0.0-rc1 milestone Jan 9, 2015
@glen-84
Copy link
Author

glen-84 commented Jan 11, 2015

Sounds good.

dougbu added a commit that referenced this issue Feb 13, 2015
dougbu added a commit that referenced this issue Feb 13, 2015
@dougbu dougbu changed the title RFC: Make directives case insensitive or allow camel case Camel-case tag helper directives Feb 13, 2015
@dougbu
Copy link
Member

dougbu commented Feb 13, 2015

Changed title from "RFC: Make directives case insensitive or allow camel case"

dougbu added a commit that referenced this issue Feb 13, 2015
@dougbu
Copy link
Member

dougbu commented Feb 13, 2015

fixed in commits fbe331c and aspnet/Mvc@451db6f

@dougbu dougbu closed this as completed Feb 13, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants