This repository was archived by the owner on Dec 19, 2018. It is now read-only.
Tag Helpers: Replace customer facing Debug.Assert's with parse errors. #174
Comments
NTaylorMullen
changed the title
NTaylorMullen
added a commit
that referenced
this issue
Oct 5, 2014
- Replaced customer facing Debug.Assert with a new error mechanism to surface errors to GenerateCode callers. - The new mechanism is a general purpose way for ISyntaxTreeRewriters to add errors to the parsing phase. #174
NTaylorMullen
added a commit
that referenced
this issue
Oct 5, 2014
- Replaced customer facing Debug.Assert with a new error mechanism to surface errors to GenerateCode callers. - The new mechanism is a general purpose way for ISyntaxTreeRewriters to add errors to the parsing phase. #174
NTaylorMullen
added a commit
that referenced
this issue
Oct 8, 2014
- Replaced customer facing Debug.Assert with a new error mechanism to surface errors to GenerateCode callers. - The new mechanism is a general purpose way for ISyntaxTreeRewriters to add errors to the parsing phase. #174
NTaylorMullen
added a commit
that referenced
this issue
Oct 9, 2014
- Replaced customer facing Debug.Assert with a new error mechanism to surface errors to GenerateCode callers. - The new mechanism is a general purpose way for ISyntaxTreeRewriters to add errors to the parsing phase. #174
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
There's 1
Debug.Assertthat is customer facing (linked below) that we need to replace with a parser error to not confuse the user. There may be more than just one customer facingDebug.Assertthat we should address. We will revisit each of these exceptions and implement correct behavior when we have time.The
Debug.Assertthat I'm referring to is: https://github.com/aspnet/Razor/blob/TagHelpersFeature/src/Microsoft.AspNet.Razor/Parser/TagHelpers/TagHelperParseTreeRewriter.cs#L32This will explode when a user has malformed
TagHelpers because it's not supported yet but will be fixed once we get #104 in. For now lets create a parser error so we don't spam users withDebug.Asserts just because they didn't right accurate HTML that happen to be tag helpers.The text was updated successfully, but these errors were encountered: