This repository was archived by the owner on Dec 19, 2018. It is now read-only.
Add error representation to IR #1412
Comments
NTaylorMullen
added a commit
that referenced
this issue
Jun 8, 2017
- Added a `Diagnostics` property and `ContainsDiagnostics` method to `RazorIRNode`. The `ContainsDiagnostics` method was necessary in order to traverse nodes without forcibly instantiating their diagnostic lists. - Added `GetAllDiagnostics` extension method for `RazorIRNode` to provide a way to retrieve all diagnostics that exist on and under a `RazorIRNode`. - Updated `RazorIRNodeWriter` to display any diagnostics that exist on IR nodes. - Internal `RazorIRNode`s do not have mutable `Diagnostics` because we don't currently add diagnostics to these elements. #1412
NTaylorMullen
added a commit
that referenced
this issue
Jun 9, 2017
- Added a `Diagnostics` property and `HasDiagnostics` method to `RazorIRNode`. The `HasDiagnostics` method was necessary in order to traverse nodes without forcibly instantiating their diagnostic lists. - Added `GetAllDiagnostics` extension method for `RazorIRNode` to provide a way to retrieve all diagnostics that exist on and under a `RazorIRNode`. - Updated `RazorIRNodeWriter` to display any diagnostics that exist on IR nodes. - Internal `RazorIRNode`s do not have mutable `Diagnostics` because we don't currently add diagnostics to these elements. - Added `DefaultIRLoweringPhaseTest` to validate that errors flow from syntax tree to IR document. Also added a missing test. - Updated the `CSharpLoweringPhaseTest`s to properly validate that errors flow from IR document => csharp document. This resulted in movement of code to the ir lowering phase tests. #1412
NTaylorMullen
added a commit
that referenced
this issue
Jun 9, 2017
- Added a `Diagnostics` property and `HasDiagnostics` method to `RazorIRNode`. The `HasDiagnostics` method was necessary in order to traverse nodes without forcibly instantiating their diagnostic lists. - Added `GetAllDiagnostics` extension method for `RazorIRNode` to provide a way to retrieve all diagnostics that exist on and under a `RazorIRNode`. - Updated `RazorIRNodeWriter` to display any diagnostics that exist on IR nodes. - Internal `RazorIRNode`s do not have mutable `Diagnostics` because we don't currently add diagnostics to these elements. - Added `DefaultIRLoweringPhaseTest` to validate that errors flow from syntax tree to IR document. Also added a missing test. - Updated the `CSharpLoweringPhaseTest`s to properly validate that errors flow from IR document => csharp document. This resulted in movement of code to the ir lowering phase tests. #1412
NTaylorMullen
added a commit
that referenced
this issue
Jun 12, 2017
- Added a `Diagnostics` property and `HasDiagnostics` method to `RazorIRNode`. The `HasDiagnostics` method was necessary in order to traverse nodes without forcibly instantiating their diagnostic lists. - Added `GetAllDiagnostics` extension method for `RazorIRNode` to provide a way to retrieve all diagnostics that exist on and under a `RazorIRNode`. - Updated `RazorIRNodeWriter` to display any diagnostics that exist on IR nodes. - Internal `RazorIRNode`s do not have mutable `Diagnostics` because we don't currently add diagnostics to these elements. - Added `DefaultIRLoweringPhaseTest` to validate that errors flow from syntax tree to IR document. Also added a missing test. - Updated the `CSharpLoweringPhaseTest`s to properly validate that errors flow from IR document => csharp document. This resulted in movement of code to the ir lowering phase tests. #1412
NTaylorMullen
added a commit
that referenced
this issue
Jun 13, 2017
- Added a `Diagnostics` and `HasDiagnostics` properties to `RazorIRNode`. The `HasDiagnostics` property was necessary in order to traverse nodes without forcibly instantiating their diagnostic lists. - Added `GetAllDiagnostics` extension method for `RazorIRNode` to provide a way to retrieve all diagnostics that exist on and under a `RazorIRNode`. - Updated `RazorIRNodeWriter` to display any diagnostics that exist on IR nodes. - Internal `RazorIRNode`s do not have mutable `Diagnostics` because we don't currently add diagnostics to these elements. - Added `DefaultIRLoweringPhaseTest` to validate that errors flow from syntax tree to IR document. Also added a missing test. - Updated the `CSharpLoweringPhaseTest`s to properly validate that errors flow from IR document => csharp document. This resulted in movement of code to the ir lowering phase tests. #1412
NTaylorMullen
added a commit
that referenced
this issue
Jun 13, 2017
- Added a `Diagnostics` and `HasDiagnostics` properties to `RazorIRNode`. The `HasDiagnostics` property was necessary in order to traverse nodes without forcibly instantiating their diagnostic lists. - Added `GetAllDiagnostics` extension method for `RazorIRNode` to provide a way to retrieve all diagnostics that exist on and under a `RazorIRNode`. - Updated `RazorIRNodeWriter` to display any diagnostics that exist on IR nodes. - Internal `RazorIRNode`s do not have mutable `Diagnostics` because we don't currently add diagnostics to these elements. - Added `DefaultIRLoweringPhaseTest` to validate that errors flow from syntax tree to IR document. Also added a missing test. - Updated the `CSharpLoweringPhaseTest`s to properly validate that errors flow from IR document => csharp document. This resulted in movement of code to the ir lowering phase tests. #1412
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Our intermediate representation doesn't currently have a way of representing
RazorDiagnostics. We should add this so we can do better error checking at the IR level.The text was updated successfully, but these errors were encountered: