Skip to content
This repository was archived by the owner on Dec 19, 2018. It is now read-only.

Add error checking for target extensions #1355

Closed
rynowak opened this issue May 17, 2017 · 2 comments
Closed

Add error checking for target extensions #1355

rynowak opened this issue May 17, 2017 · 2 comments
Assignees
@rynowak
Labels
3 - Done enhancement
Milestone
2.0.0

Comments

@rynowak
Copy link
Member

rynowak commented May 17, 2017

Right now we don't check for the absence of target extensions when we render an extension node. This means that we could null-ref instead of reporting an error.
@rynowak
Copy link
Member Author

rynowak commented May 17, 2017

Here's an example of what this looks like https://github.com/aspnet/Razor/pull/1357/files#diff-9c6d50b13b132c9feed9b3f0e7becd43R31

@rynowak rynowak closed this as completed May 17, 2017
@rynowak rynowak reopened this May 17, 2017
@rynowak rynowak added this to the 2.0.0-preview3 milestone May 17, 2017
@rynowak rynowak self-assigned this Jun 6, 2017
rynowak added a commit that referenced this issue Jun 6, 2017
@rynowak
Fix #1355 Make extension nodes check for their extensions
7770136
@rynowak rynowak closed this as completed in 17800b6 Jun 9, 2017
@rynowak
Copy link
Member Author

rynowak commented Jun 9, 2017

17800b6

@Eilon Eilon added 3 - Done and removed 2 - Working labels Jun 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rynowak rynowak

Labels
3 - Done enhancement
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@Eilon @rynowak