Skip to content
This repository was archived by the owner on Dec 19, 2018. It is now read-only.

Consider not providing catch-all IntelliSense to existing completions. #1230

Closed
NTaylorMullen opened this issue Apr 14, 2017 · 5 comments
Closed

Consider not providing catch-all IntelliSense to existing completions. #1230

NTaylorMullen opened this issue Apr 14, 2017 · 5 comments
Assignees
@NTaylorMullen
Labels
3 - Done enhancement
Milestone
2.0.0-preview2

Comments

@NTaylorMullen
Copy link
Contributor

Today our DefaultTagHelperElementCompletionService will mark every completion with a catch-all TagHelper if it exists. Aka you get a massive list of TagHelperified elements:
image

This is consistent with how TagHelper IntelliSense has worked in the past but it doesn't seem useful. It might be better to exclude catch-all based TagHelpers entirely from IntelliSense completion. This way a catch-all TagHelper that has required attributes will only light up when its required attributes have been satisfied. It also means we wont be polluting the completion lists with excess amounts of TagHelpers.
@rynowak
Copy link
Member

rynowak commented Apr 14, 2017

@DamianEdwards - do you have an opinion on this behavior?

@rynowak rynowak removed the Evolution label Apr 14, 2017
@DamianEdwards
Copy link
Member

Agree with @NTaylorMullen. I'm assuming the attributes on said Tag Helpers will still show up though, yes?

@rynowak
Copy link
Member

rynowak commented Apr 14, 2017

Ok. I'm going to slot this into preview-2. For preview-1 we're going to have the behavior Dev14 had here.

@rynowak rynowak added this to the 2.0.0-preview2 milestone Apr 14, 2017
@NTaylorMullen
Copy link
Contributor Author

I'm assuming the attributes on said Tag Helpers will still show up though, yes?

Yes.

NTaylorMullen added a commit that referenced this issue May 5, 2017
@NTaylorMullen
Reduce catch all element completion usage.
242e209 
- This makes it so if you have catch all `TagHelperDescriptor`s their completions don't apply to every existing completion. Instead, they now only apply to already TagHelperified completions and existing completions that are prefixed with a non-empty TagHelperPrefix.
- Updated existing test to have new expectations.
- Added new test to validate non-empty tag helper prefix case.

#1230
@NTaylorMullen NTaylorMullen mentioned this issue May 5, 2017
Merged
NTaylorMullen added a commit that referenced this issue May 8, 2017
@NTaylorMullen
Reduce catch all element completion usage.
a358bb1 
- This makes it so if you have catch all `TagHelperDescriptor`s their completions don't apply to every existing completion. Instead, they now only apply to already TagHelperified completions and existing completions that are prefixed with a non-empty TagHelperPrefix.
- Updated existing test to have new expectations.
- Added new test to validate non-empty tag helper prefix case.

#1230
NTaylorMullen added a commit that referenced this issue May 8, 2017
@NTaylorMullen
Reduce catch all element completion usage.
e87011f 
- This makes it so if you have catch all `TagHelperDescriptor`s their completions don't apply to every existing completion. Instead, they now only apply to already TagHelperified completions and existing completions that are prefixed with a non-empty TagHelperPrefix.
- Updated existing test to have new expectations.
- Added new test to validate non-empty tag helper prefix case.

#1230
@NTaylorMullen
Copy link
Contributor Author

e87011f

NTaylorMullen added a commit that referenced this issue May 9, 2017
@NTaylorMullen
Reduce catch all element completion usage.
d24996e 
- This makes it so if you have catch all `TagHelperDescriptor`s their completions don't apply to every existing completion. Instead, they now only apply to already TagHelperified completions and existing completions that are prefixed with a non-empty TagHelperPrefix.
- Updated existing test to have new expectations.
- Added new test to validate non-empty tag helper prefix case.

#1230
NTaylorMullen added a commit that referenced this issue May 9, 2017
@NTaylorMullen
Reduce catch all element completion usage.
d54e7af 
- This makes it so if you have catch all `TagHelperDescriptor`s their completions don't apply to every existing completion. Instead, they now only apply to already TagHelperified completions and existing completions that are prefixed with a non-empty TagHelperPrefix.
- Updated existing test to have new expectations.
- Added new test to validate non-empty tag helper prefix case.

#1230
NTaylorMullen added a commit that referenced this issue May 10, 2017
@NTaylorMullen
Reduce catch all element completion usage.
8ea83b4 
- This makes it so if you have catch all `TagHelperDescriptor`s their completions don't apply to every existing completion. Instead, they now only apply to already TagHelperified completions and existing completions that are prefixed with a non-empty TagHelperPrefix.
- Updated existing test to have new expectations.
- Added new test to validate non-empty tag helper prefix case.

#1230
NTaylorMullen added a commit that referenced this issue May 16, 2017
@NTaylorMullen
Reduce catch all element completion usage.
8616cf5 
- This makes it so if you have catch all `TagHelperDescriptor`s their completions don't apply to every existing completion. Instead, they now only apply to already TagHelperified completions and existing completions that are prefixed with a non-empty TagHelperPrefix.
- Updated existing test to have new expectations.
- Added new test to validate non-empty tag helper prefix case.

#1230
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NTaylorMullen NTaylorMullen

Labels
3 - Done enhancement
Projects
None yet
Milestone
2.0.0-preview2
Development

No branches or pull requests
3 participants
@DamianEdwards @rynowak @NTaylorMullen