Skip to content
This repository was archived by the owner on Dec 19, 2018. It is now read-only.

Tag Helpers: Make Attribute Code Generation pluggable. #119

Closed
NTaylorMullen opened this issue Sep 8, 2014 · 1 comment
Closed

Tag Helpers: Make Attribute Code Generation pluggable. #119

NTaylorMullen opened this issue Sep 8, 2014 · 1 comment
Assignees
@NTaylorMullen
Labels
3 - Done enhancement
Milestone
1.0.0-beta1

Comments

@NTaylorMullen
Copy link
Contributor

Need to add support for TagHelper attribute code generation plugability.

This involves adding an extensibility point for Mvc to provide its own tag helper attribute code generator.
@NTaylorMullen NTaylorMullen self-assigned this Sep 8, 2014
@NTaylorMullen NTaylorMullen added this to the 4.0.0-beta1 milestone Sep 8, 2014
@NTaylorMullen NTaylorMullen mentioned this issue Sep 8, 2014
Merged
This was referenced Sep 13, 2014
Closed
Merged
@NTaylorMullen NTaylorMullen changed the title Tag Helpers: Attribute Code Generation Tag Helpers: Make Attribute Code Generation pluggable. Sep 15, 2014
NTaylorMullen added a commit that referenced this issue Sep 15, 2014
@NTaylorMullen
Add extensibility point for TH attribute code gen.
c19b654 
- Followed the "decorate" pattern that we use throughout Razor.
- Enabled the CSharpCodeBuilder to decorate the CSharpCodeVisitor which exposes a CSharpTagHelperCodeRenderer which is indirectly used to render attribute values.
- Fixed up some existing classes that just new'd up the CSharpCodeVisitor class to instead take in the decorated version.

#119
NTaylorMullen added a commit that referenced this issue Sep 15, 2014
@NTaylorMullen
Add test for TagHelperAttributeCodeGenerator extensibility.
ee388f4 
- Tested that we can successfully plugin our own TagHelperAttributeCodeGenerator.
- Moved some existing TagHelper test logic into its own base type to enhance code reusability.

#119
NTaylorMullen added a commit that referenced this issue Sep 15, 2014
@NTaylorMullen
Add test for TagHelperAttributeCodeGenerator extensibility.
3f2fa4a 
- Tested that we can successfully plugin our own TagHelperAttributeCodeGenerator.
- Moved some existing TagHelper test logic into its own base type to enhance code reusability.

#119
@NTaylorMullen NTaylorMullen mentioned this issue Sep 15, 2014
Closed
NTaylorMullen added a commit that referenced this issue Sep 19, 2014
@NTaylorMullen
Add extensibility point for TH attribute code gen.
bccc3d4 
- Followed the "decorate" pattern that we use throughout Razor.
- Enabled the CSharpCodeBuilder to decorate the CSharpCodeVisitor which exposes a CSharpTagHelperCodeRenderer which is indirectly used to render attribute values.
- Fixed up some existing classes that just new'd up the CSharpCodeVisitor class to instead take in the decorated version.

#119
NTaylorMullen added a commit that referenced this issue Sep 19, 2014
@NTaylorMullen
Add test for TagHelperAttributeCodeGenerator extensibility.
6a99ea3 
- Tested that we can successfully plugin our own TagHelperAttributeCodeGenerator.
- Moved some existing TagHelper test logic into its own base type to enhance code reusability.

#119
NTaylorMullen added a commit that referenced this issue Sep 23, 2014
@NTaylorMullen
Add extensibility point for TH attribute code gen.
4ff7123 
- Followed the "decorate" pattern that we use throughout Razor.
- Enabled the CSharpCodeBuilder to decorate the CSharpCodeVisitor which exposes a CSharpTagHelperCodeRenderer which is indirectly used to render attribute values.
- Fixed up some existing classes that just new'd up the CSharpCodeVisitor class to instead take in the decorated version.

#119
NTaylorMullen added a commit that referenced this issue Sep 23, 2014
@NTaylorMullen
Add test for TagHelperAttributeCodeGenerator extensibility.
c80b01f 
- Tested that we can successfully plugin our own TagHelperAttributeCodeGenerator.
- Moved some existing TagHelper test logic into its own base type to enhance code reusability.

#119
NTaylorMullen added a commit that referenced this issue Sep 24, 2014
@NTaylorMullen
Add extensibility point for TH attribute code gen.
58eb8d1 
- Followed the "decorate" pattern that we use throughout Razor.
- Enabled the CSharpCodeBuilder to decorate the CSharpCodeVisitor which exposes a CSharpTagHelperCodeRenderer which is indirectly used to render attribute values.
- Fixed up some existing classes that just new'd up the CSharpCodeVisitor class to instead take in the decorated version.

#119
NTaylorMullen added a commit that referenced this issue Sep 24, 2014
@NTaylorMullen
Add test for TagHelperAttributeCodeGenerator extensibility.
b558551 
- Tested that we can successfully plugin our own TagHelperAttributeCodeGenerator.
- Moved some existing TagHelper test logic into its own base type to enhance code reusability.

#119
NTaylorMullen added a commit that referenced this issue Sep 25, 2014
@NTaylorMullen
Add extensibility point for TH attribute code gen.
6fbb43c 
- Followed the "decorate" pattern that we use throughout Razor.
- Enabled the CSharpCodeBuilder to decorate the CSharpCodeVisitor which exposes a CSharpTagHelperCodeRenderer which is indirectly used to render attribute values.
- Fixed up some existing classes that just new'd up the CSharpCodeVisitor class to instead take in the decorated version.

#119
NTaylorMullen added a commit that referenced this issue Sep 25, 2014
@NTaylorMullen
Add test for TagHelperAttributeCodeGenerator extensibility.
ffa150d 
- Tested that we can successfully plugin our own TagHelperAttributeCodeGenerator.
- Moved some existing TagHelper test logic into its own base type to enhance code reusability.

#119
NTaylorMullen added a commit that referenced this issue Sep 25, 2014
@NTaylorMullen
Add extensibility point for TH attribute code gen.
84e32d5 
- Followed the "decorate" pattern that we use throughout Razor.
- Enabled the CSharpCodeBuilder to decorate the CSharpCodeVisitor which exposes a CSharpTagHelperCodeRenderer which is indirectly used to render attribute values.
- Fixed up some existing classes that just new'd up the CSharpCodeVisitor class to instead take in the decorated version.

#119
NTaylorMullen added a commit that referenced this issue Sep 25, 2014
@NTaylorMullen
Add test for TagHelperAttributeCodeGenerator extensibility.
47bd7e4 
- Tested that we can successfully plugin our own TagHelperAttributeCodeGenerator.
- Moved some existing TagHelper test logic into its own base type to enhance code reusability.

#119
NTaylorMullen added a commit that referenced this issue Sep 26, 2014
@NTaylorMullen
Add extensibility point for TH attribute code gen.
2456737 
- Followed the "decorate" pattern that we use throughout Razor.
- Enabled the CSharpCodeBuilder to decorate the CSharpCodeVisitor which exposes a CSharpTagHelperCodeRenderer which is indirectly used to render attribute values.
- Fixed up some existing classes that just new'd up the CSharpCodeVisitor class to instead take in the decorated version.

#119
NTaylorMullen added a commit that referenced this issue Sep 26, 2014
@NTaylorMullen
Add test for TagHelperAttributeCodeGenerator extensibility.
c2000bc 
- Tested that we can successfully plugin our own TagHelperAttributeCodeGenerator.
- Moved some existing TagHelper test logic into its own base type to enhance code reusability.

#119
NTaylorMullen added a commit that referenced this issue Sep 29, 2014
@NTaylorMullen
Add extensibility point for TH attribute code gen.
5c5bd8e 
- Followed the "decorate" pattern that we use throughout Razor.
- Enabled the CSharpCodeBuilder to decorate the CSharpCodeVisitor which exposes a CSharpTagHelperCodeRenderer which is indirectly used to render attribute values.
- Fixed up some existing classes that just new'd up the CSharpCodeVisitor class to instead take in the decorated version.

#119
NTaylorMullen added a commit that referenced this issue Sep 29, 2014
@NTaylorMullen
Add test for TagHelperAttributeCodeGenerator extensibility.
11b1fdb 
- Tested that we can successfully plugin our own TagHelperAttributeCodeGenerator.
- Moved some existing TagHelper test logic into its own base type to enhance code reusability.

#119
NTaylorMullen added a commit that referenced this issue Sep 29, 2014
@NTaylorMullen
Add extensibility point for TH attribute code gen.
2cfd3c2 
- Followed the "decorate" pattern that we use throughout Razor.
- Enabled the CSharpCodeBuilder to decorate the CSharpCodeVisitor which exposes a CSharpTagHelperCodeRenderer which is indirectly used to render attribute values.
- Fixed up some existing classes that just new'd up the CSharpCodeVisitor class to instead take in the decorated version.

#119
NTaylorMullen added a commit that referenced this issue Sep 29, 2014
@NTaylorMullen
Add test for TagHelperAttributeCodeGenerator extensibility.
2d3d8f3 
- Tested that we can successfully plugin our own TagHelperAttributeCodeGenerator.
- Moved some existing TagHelper test logic into its own base type to enhance code reusability.

#119
NTaylorMullen added a commit that referenced this issue Sep 29, 2014
@NTaylorMullen
Add extensibility point for TH attribute code gen.
5bbc22d 
- Followed the "decorate" pattern that we use throughout Razor.
- Enabled the CSharpCodeBuilder to decorate the CSharpCodeVisitor which exposes a CSharpTagHelperCodeRenderer which is indirectly used to render attribute values.
- Fixed up some existing classes that just new'd up the CSharpCodeVisitor class to instead take in the decorated version.

#119
NTaylorMullen added a commit that referenced this issue Sep 29, 2014
@NTaylorMullen
Add test for TagHelperAttributeCodeGenerator extensibility.
6a5bbe1 
- Tested that we can successfully plugin our own TagHelperAttributeCodeGenerator.
- Moved some existing TagHelper test logic into its own base type to enhance code reusability.

#119
NTaylorMullen added a commit that referenced this issue Sep 29, 2014
@NTaylorMullen
Add extensibility point for TH attribute code gen.
8a8d46a 
- Followed the "decorate" pattern that we use throughout Razor.
- Enabled the CSharpCodeBuilder to decorate the CSharpCodeVisitor which exposes a CSharpTagHelperCodeRenderer which is indirectly used to render attribute values.
- Fixed up some existing classes that just new'd up the CSharpCodeVisitor class to instead take in the decorated version.

#119
NTaylorMullen added a commit that referenced this issue Sep 29, 2014
@NTaylorMullen
Add test for TagHelperAttributeCodeGenerator extensibility.
b74be5c 
- Tested that we can successfully plugin our own TagHelperAttributeCodeGenerator.
- Moved some existing TagHelper test logic into its own base type to enhance code reusability.

#119
NTaylorMullen added a commit that referenced this issue Sep 30, 2014
@NTaylorMullen
Add extensibility point for TH attribute code gen.
48cdc40 
- Followed the "decorate" pattern that we use throughout Razor.
- Enabled the CSharpCodeBuilder to decorate the CSharpCodeVisitor which exposes a CSharpTagHelperCodeRenderer which is indirectly used to render attribute values.
- Fixed up some existing classes that just new'd up the CSharpCodeVisitor class to instead take in the decorated version.

#119
NTaylorMullen added a commit that referenced this issue Sep 30, 2014
@NTaylorMullen
Add test for TagHelperAttributeCodeGenerator extensibility.
9a52098 
- Tested that we can successfully plugin our own TagHelperAttributeCodeGenerator.
- Moved some existing TagHelper test logic into its own base type to enhance code reusability.

#119
NTaylorMullen added a commit that referenced this issue Sep 30, 2014
@NTaylorMullen
Add extensibility point for TH attribute code gen.
ce4b6fa 
- Followed the "decorate" pattern that we use throughout Razor.
- Enabled the CSharpCodeBuilder to decorate the CSharpCodeVisitor which exposes a CSharpTagHelperCodeRenderer which is indirectly used to render attribute values.
- Fixed up some existing classes that just new'd up the CSharpCodeVisitor class to instead take in the decorated version.

#119
NTaylorMullen added a commit that referenced this issue Sep 30, 2014
@NTaylorMullen
Add test for TagHelperAttributeCodeGenerator extensibility.
7377d99 
- Tested that we can successfully plugin our own TagHelperAttributeCodeGenerator.
- Moved some existing TagHelper test logic into its own base type to enhance code reusability.

#119
NTaylorMullen added a commit that referenced this issue Oct 1, 2014
@NTaylorMullen
Add extensibility point for TH attribute code gen.
318bb6e 
- Followed the "decorate" pattern that we use throughout Razor.
- Enabled the CSharpCodeBuilder to decorate the CSharpCodeVisitor which exposes a CSharpTagHelperCodeRenderer which is indirectly used to render attribute values.
- Fixed up some existing classes that just new'd up the CSharpCodeVisitor class to instead take in the decorated version.

#119
NTaylorMullen added a commit that referenced this issue Oct 1, 2014
@NTaylorMullen
Add test for TagHelperAttributeCodeGenerator extensibility.
64822c3 
- Tested that we can successfully plugin our own TagHelperAttributeCodeGenerator.
- Moved some existing TagHelper test logic into its own base type to enhance code reusability.

#119
NTaylorMullen added a commit that referenced this issue Oct 1, 2014
@NTaylorMullen
Add extensibility point for TH attribute code gen.
36d5151 
- Followed the "decorate" pattern that we use throughout Razor.
- Enabled the CSharpCodeBuilder to decorate the CSharpCodeVisitor which exposes a CSharpTagHelperCodeRenderer which is indirectly used to render attribute values.
- Fixed up some existing classes that just new'd up the CSharpCodeVisitor class to instead take in the decorated version.

#119
NTaylorMullen added a commit that referenced this issue Oct 1, 2014
@NTaylorMullen
Add test for TagHelperAttributeCodeGenerator extensibility.
05b9266 
- Tested that we can successfully plugin our own TagHelperAttributeCodeGenerator.
- Moved some existing TagHelper test logic into its own base type to enhance code reusability.

#119
NTaylorMullen added a commit that referenced this issue Oct 2, 2014
@NTaylorMullen
Add extensibility point for TH attribute code gen.
1fb909a 
- Followed the "decorate" pattern that we use throughout Razor.
- Enabled the CSharpCodeBuilder to decorate the CSharpCodeVisitor which exposes a CSharpTagHelperCodeRenderer which is indirectly used to render attribute values.
- Fixed up some existing classes that just new'd up the CSharpCodeVisitor class to instead take in the decorated version.

#119
NTaylorMullen added a commit that referenced this issue Oct 2, 2014
@NTaylorMullen
Add test for TagHelperAttributeCodeGenerator extensibility.
033b6ad 
- Tested that we can successfully plugin our own TagHelperAttributeCodeGenerator.
- Moved some existing TagHelper test logic into its own base type to enhance code reusability.

#119
NTaylorMullen added a commit that referenced this issue Oct 2, 2014
@NTaylorMullen
Add extensibility point for TH attribute code gen.
2ed47f7 
- Followed the "decorate" pattern that we use throughout Razor.
- Enabled the CSharpCodeBuilder to decorate the CSharpCodeVisitor which exposes a CSharpTagHelperCodeRenderer which is indirectly used to render attribute values.
- Fixed up some existing classes that just new'd up the CSharpCodeVisitor class to instead take in the decorated version.

#119
NTaylorMullen added a commit that referenced this issue Oct 2, 2014
@NTaylorMullen
Add test for TagHelperAttributeCodeGenerator extensibility.
f3d6872 
- Tested that we can successfully plugin our own TagHelperAttributeCodeGenerator.
- Moved some existing TagHelper test logic into its own base type to enhance code reusability.

#119
NTaylorMullen added a commit that referenced this issue Oct 2, 2014
@NTaylorMullen
Add extensibility point for TH attribute code gen.
4c75bd8 
- Followed the "decorate" pattern that we use throughout Razor.
- Enabled the CSharpCodeBuilder to decorate the CSharpCodeVisitor which exposes a CSharpTagHelperCodeRenderer which is indirectly used to render attribute values.
- Fixed up some existing classes that just new'd up the CSharpCodeVisitor class to instead take in the decorated version.

#119
NTaylorMullen added a commit that referenced this issue Oct 2, 2014
@NTaylorMullen
Add test for TagHelperAttributeCodeGenerator extensibility.
6843937 
- Tested that we can successfully plugin our own TagHelperAttributeCodeGenerator.
- Moved some existing TagHelper test logic into its own base type to enhance code reusability.

#119
NTaylorMullen added a commit that referenced this issue Oct 3, 2014
@NTaylorMullen
Add extensibility point for TH attribute code gen.
15b7e15 
- Enabled the CSharpCodeBuilder to create the CSharpCodeVisitor which exposes a CSharpTagHelperCodeRenderer which is indirectly used to render attribute values.
- Fixed up some existing classes that just new'd up the CSharpCodeVisitor class to instead take in the decorated version.

#119
NTaylorMullen added a commit that referenced this issue Oct 3, 2014
@NTaylorMullen
Add test for TagHelperAttributeValueCodeRenderer extensibility.
7399531 
- Tested that we can successfully plugin our own TagHelperAttributeValueCodeRenderer.
- Moved some existing TagHelper test logic into its own base type to enhance code reusability.

#119
@NTaylorMullen
Copy link
Contributor Author

2b6b437
05d8193

NTaylorMullen added a commit that referenced this issue Oct 5, 2014
@NTaylorMullen
Add extensibility point for TH attribute code gen.
5466e2f 
- Enabled the CSharpCodeBuilder to create the CSharpCodeVisitor which exposes a CSharpTagHelperCodeRenderer which is indirectly used to render attribute values.
- Fixed up some existing classes that just new'd up the CSharpCodeVisitor class to instead take in the decorated version.

#119
NTaylorMullen added a commit that referenced this issue Oct 5, 2014
@NTaylorMullen
Add test for TagHelperAttributeValueCodeRenderer extensibility.
6ef8ec4 
- Tested that we can successfully plugin our own TagHelperAttributeValueCodeRenderer.
- Moved some existing TagHelper test logic into its own base type to enhance code reusability.

#119
NTaylorMullen added a commit that referenced this issue Oct 9, 2014
@NTaylorMullen
Add extensibility point for TH attribute code gen.
2b6b437 
- Enabled the CSharpCodeBuilder to create the CSharpCodeVisitor which exposes a CSharpTagHelperCodeRenderer which is indirectly used to render attribute values.
- Fixed up some existing classes that just new'd up the CSharpCodeVisitor class to instead take in the decorated version.

#119
NTaylorMullen added a commit that referenced this issue Oct 9, 2014
@NTaylorMullen
Add test for TagHelperAttributeValueCodeRenderer extensibility.
05d8193 
- Tested that we can successfully plugin our own TagHelperAttributeValueCodeRenderer.
- Moved some existing TagHelper test logic into its own base type to enhance code reusability.

#119
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NTaylorMullen NTaylorMullen

Labels
3 - Done enhancement
Projects
None yet
Milestone
1.0.0-beta1
Development

No branches or pull requests
1 participant
@NTaylorMullen