Skip to content
This repository was archived by the owner on Dec 19, 2018. It is now read-only.

Add TagHelper completions API to TagHelperFactService. #1181

Closed
NTaylorMullen opened this issue Apr 5, 2017 · 2 comments
Closed

Add TagHelper completions API to TagHelperFactService. #1181

NTaylorMullen opened this issue Apr 5, 2017 · 2 comments

Comments

@NTaylorMullen
Copy link
Contributor

Today we expose several APIs that control the binding of TagHelpers to a given HTML element based on the tag name and presence of attributes; we should own the entire completion API.

@rynowak
Copy link
Member

rynowak commented Apr 5, 2017

The title of this is jankified. This would be a new, completion-focused service.

NTaylorMullen added a commit that referenced this issue Apr 11, 2017
- Added a new `TagHelperCompletionFactService` which can be queried for information on what completion information should be provided.
- Added tests to validate the completion service's expectations.
- Fixed an issue where `TagHelper`s with output hints that did not exist in a passed in completion would never be highlighted as `TagHelper`'s; even when their primary targeting element was already in the element completion list.

#1181
NTaylorMullen added a commit that referenced this issue Apr 11, 2017
- Added a new `TagHelperCompletionFactService` which can be queried for information on what completion information should be provided.
- Added tests to validate the completion service's expectations.
- Fixed an issue where `TagHelper`s with output hints that did not exist in a passed in completion would never be highlighted as `TagHelper`'s; even when their primary targeting element was already in the element completion list.

#1181
NTaylorMullen added a commit that referenced this issue Apr 12, 2017
- Added a new `TagHelperCompletionService` which can be queried for information on what completion information should be provided.
- Added tests to validate the completion service's expectations.
- Fixed an issue where `TagHelper`s with output hints that did not exist in a passed in completion would never be highlighted as `TagHelper`'s; even when their primary targeting element was already in the element completion list.

#1181
NTaylorMullen added a commit that referenced this issue Apr 12, 2017
- Added a new `TagHelperCompletionService` which can be queried for information on what completion information should be provided.
- Added tests to validate the completion service's expectations.
- Fixed an issue where `TagHelper`s with output hints that did not exist in a passed in completion would never be highlighted as `TagHelper`'s; even when their primary targeting element was already in the element completion list.

#1181
@NTaylorMullen
Copy link
Contributor Author

a1cfd22

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants