Skip to content
This repository was archived by the owner on Dec 19, 2018. It is now read-only.

Implement TagHelperCompletionService #1120

Closed
NTaylorMullen opened this issue Mar 24, 2017 · 4 comments
Closed

Implement TagHelperCompletionService #1120

NTaylorMullen opened this issue Mar 24, 2017 · 4 comments
Assignees
@NTaylorMullen
Labels
3 - Done enhancement
Milestone
2.0.0-preview2

Comments

@NTaylorMullen
Copy link
Contributor

The Razor editor currently has in-depth knowledge of how TagHelpers apply to an HTML element, its attributes and the overall document. We should abstract this knowledge into a service.
@NTaylorMullen NTaylorMullen added this to the 2.0.0-preview1 milestone Mar 24, 2017
@NTaylorMullen NTaylorMullen self-assigned this Mar 24, 2017
@rynowak
Copy link
Member

rynowak commented Mar 24, 2017 •
edited
Loading

I'd also recommend here that we separate the completion apis into their own service.

NTaylorMullen added a commit that referenced this issue Mar 27, 2017
@NTaylorMullen
Add TagHelperFactsService.
3ba065f 
- Add API to enable the editor to query information on the state of `TagHelper`s within a Razor document.
- Refactored methods from `TagHelperDescriptorProvider` to be public static so our language service could use them.

#1120
@NTaylorMullen NTaylorMullen mentioned this issue Mar 27, 2017
Merged
NTaylorMullen added a commit that referenced this issue Mar 28, 2017
@NTaylorMullen
Add TagHelperFactsService.
b08bab3 
- Add API to enable the editor to query information on the state of `TagHelper`s within a Razor document.
- Refactored methods from `TagHelperDescriptorProvider` to be public static so our language service could use them.

#1120
NTaylorMullen added a commit that referenced this issue Mar 28, 2017
@NTaylorMullen
Add TagHelperFactsService.
3b058a7 
- Add API to enable the editor to query information on the state of `TagHelper`s within a Razor document.
- Refactored methods from `TagHelperDescriptorProvider` to be public static so our language service could use them.

#1120
NTaylorMullen added a commit that referenced this issue Mar 28, 2017
@NTaylorMullen
Add TagHelperFactsService.
f796f65 
- Add API to enable the editor to query information on the state of `TagHelper`s within a Razor document.
- Refactored methods from `TagHelperDescriptorProvider` to be public static so our language service could use them.

#1120
NTaylorMullen added a commit that referenced this issue Mar 28, 2017
@NTaylorMullen
Add TagHelperFactsService.
ab02bb8 
- Add API to enable the editor to query information on the state of `TagHelper`s within a Razor document.
- Refactored methods from `TagHelperDescriptorProvider` to be in a `TagHelperDescriptorConventions` class so the language service could use them.

#1120
NTaylorMullen added a commit that referenced this issue Mar 29, 2017
@NTaylorMullen
Add TagHelperFactsService.
207286d 
- Add API to enable the editor to query information on the state of `TagHelper`s within a Razor document.
- Refactored methods from `TagHelperDescriptorProvider` to be in a `TagHelperDescriptorConventions` class so the language service could use them.
- Added `DefaultTagHelperFactService` tests.

#1120
NTaylorMullen added a commit that referenced this issue Mar 29, 2017
@NTaylorMullen
Add TagHelperFactsService.
22c7c90 
- Add API to enable the editor to query information on the state of `TagHelper`s within a Razor document.
- Refactored methods from `TagHelperDescriptorProvider` to be in a `TagHelperDescriptorConventions` class so the language service could use them.
- Added `DefaultTagHelperFactService` tests.

#1120
@NTaylorMullen
Copy link
Contributor Author

22c7c90

Not closing because more bits will probably flow through this.

@rynowak rynowak changed the title Define a TagHelperFactService Implement TagHelperCompletionService Apr 14, 2017
@rynowak
Copy link
Member

rynowak commented Apr 14, 2017

We've implemented completion for HTML elements.

The remaining work here is to implement completion for attributes.

Moving the remaining work out of preview 1.

@rynowak rynowak removed the Evolution label Apr 14, 2017
NTaylorMullen added a commit that referenced this issue May 3, 2017
@NTaylorMullen
Add AttributeCompletion API.
a8a61a0 
- Added a `GetAttributeCompletions` API that's consistent with current Razor's editor expectations.
- Added unit tests to validate all code paths of the new `GetAttributeCompletions` method.

#1120
NTaylorMullen added a commit that referenced this issue May 3, 2017
@NTaylorMullen
Add AttributeCompletion API.
bcb4c0f 
- Added a `GetAttributeCompletions` API that's consistent with current Razor's editor expectations.
- Added unit tests to validate all code paths of the new `GetAttributeCompletions` method.

#1120
@NTaylorMullen NTaylorMullen mentioned this issue May 3, 2017
Merged
NTaylorMullen added a commit that referenced this issue May 4, 2017
@NTaylorMullen
Add AttributeCompletion API.
fd21ea0 
- Added a `GetAttributeCompletions` API that's consistent with current Razor's editor expectations.
- Added unit tests to validate all code paths of the new `GetAttributeCompletions` method.

#1120
NTaylorMullen added a commit that referenced this issue May 5, 2017
@NTaylorMullen
Add AttributeCompletion API.
cc44b70 
- Added a `GetAttributeCompletions` API that's consistent with current Razor's editor expectations.
- Added unit tests to validate all code paths of the new `GetAttributeCompletions` method.

#1120
NTaylorMullen added a commit that referenced this issue May 5, 2017
@NTaylorMullen
Add AttributeCompletion API.
90eece6 
- Added a `GetAttributeCompletions` API that's consistent with current Razor's editor expectations.
- Added unit tests to validate all code paths of the new `GetAttributeCompletions` method.

#1120
NTaylorMullen added a commit that referenced this issue May 5, 2017
@NTaylorMullen
Add AttributeCompletion API.
1795fc2 
- Added a `GetAttributeCompletions` API that's consistent with current Razor's editor expectations.
- Added unit tests to validate all code paths of the new `GetAttributeCompletions` method.

#1120
@NTaylorMullen
Copy link
Contributor Author

22c7c90
1795fc2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NTaylorMullen NTaylorMullen

Labels
3 - Done enhancement
Projects
None yet
Milestone
2.0.0-preview2
Development

No branches or pull requests
2 participants
@rynowak @NTaylorMullen