Skip to content
This repository was archived by the owner on Dec 19, 2018. It is now read-only.

TagHelperBinding needs to include more information #1092

Closed
rynowak opened this issue Mar 20, 2017 · 3 comments
Closed

TagHelperBinding needs to include more information #1092

rynowak opened this issue Mar 20, 2017 · 3 comments
Assignees
@NTaylorMullen
Labels
3 - Done breaking-change enhancement
Milestone
2.0.0-preview2

Comments

@rynowak
Copy link
Member

rynowak commented Mar 20, 2017 •
edited
Loading

It would be great if TagHelperBinding included more information:

  • What was the tag?
  • What was the tag helper prefix?
  • Maybe some info about the attributes?
@rynowak rynowak added this to the 2.0.0-preview1 milestone Mar 20, 2017
@rynowak
Copy link
Member Author

rynowak commented Mar 20, 2017

Also TagHelperBinding should not be in Legacy 👍

@rynowak rynowak removed the Evolution label Apr 14, 2017
@rynowak
Copy link
Member Author

rynowak commented May 3, 2017

It turns out that tooling uses this type directly. This is going to be a breaking change for them.

NTaylorMullen added a commit that referenced this issue May 8, 2017
@NTaylorMullen
Move TagHelperBinding out of Legacy.
2f0ae94 
- Added additional properties to the class to make it more production ready.

#1092
@NTaylorMullen NTaylorMullen mentioned this issue May 8, 2017
Merged
NTaylorMullen added a commit that referenced this issue May 8, 2017
@NTaylorMullen
Move TagHelperBinding out of Legacy.
8a0ba9e 
- Added additional properties to the class to make it more production ready.

#1092
NTaylorMullen added a commit that referenced this issue May 8, 2017
@NTaylorMullen
Move TagHelperBinding out of Legacy.
086808e 
- Added additional properties to the class to make it more production ready.

#1092
NTaylorMullen added a commit that referenced this issue May 9, 2017
@NTaylorMullen
Move TagHelperBinding out of Legacy.
9d9fca5 
- Added additional properties to the class to make it more production ready.

#1092
NTaylorMullen added a commit that referenced this issue May 9, 2017
@NTaylorMullen
Move TagHelperBinding out of Legacy.
a268b82 
- Added additional properties to the class to make it more production ready.

#1092
NTaylorMullen added a commit that referenced this issue May 9, 2017
@NTaylorMullen
Move TagHelperBinding out of Legacy.
45a62d8 
- Added additional properties to the class to make it more production ready.

#1092
NTaylorMullen added a commit that referenced this issue May 9, 2017
@NTaylorMullen
Move TagHelperBinding out of Legacy.
5504a47 
- Added additional properties to the class to make it more production ready.

#1092
@NTaylorMullen
Copy link
Contributor

5504a47

NTaylorMullen added a commit that referenced this issue May 9, 2017
@NTaylorMullen
Move TagHelperBinding out of Legacy.
5a1acf2 
- Added additional properties to the class to make it more production ready.

#1092
NTaylorMullen added a commit that referenced this issue May 10, 2017
@NTaylorMullen
Move TagHelperBinding out of Legacy.
c650567 
- Added additional properties to the class to make it more production ready.

#1092
NTaylorMullen added a commit that referenced this issue May 16, 2017
@NTaylorMullen
Move TagHelperBinding out of Legacy.
9fe7c77 
- Added additional properties to the class to make it more production ready.

#1092
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NTaylorMullen NTaylorMullen

Labels
3 - Done breaking-change enhancement
Projects
None yet
Milestone
2.0.0-preview2
Development

No branches or pull requests
2 participants
@rynowak @NTaylorMullen