Skip to content
This repository was archived by the owner on Dec 19, 2018. It is now read-only.

Commit

Permalink
Modify parser to group html begin/end elements.
Browse files Browse the repository at this point in the history 
- Added a "Tag" block type.
- Wrapped all begin/end elements in a "Tag" Markup block.

#75
  • Loading branch information
@NTaylorMullen
NTaylorMullen committed Aug 13, 2014
1 parent 8aef9ff commit 3767597
Show file tree
Hide file tree
Showing 4 changed files with 210 additions and 59 deletions.
186 changes: 153 additions & 33 deletions src/Microsoft.AspNet.Razor/Parser/HtmlMarkupParser.Block.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,19 @@ private void TagBlock(Stack<Tuple<HtmlSymbol, SourceLocation>> tags)
do
{
SkipToAndParseCode(HtmlSymbolType.OpenAngle);

// Output everything prior to the OpenAngle into a markup span
Output(SpanKind.Markup);

IDisposable tagBlock = null;
// Do not want to start a new tag block if we're at the end of the file.
if (!EndOfFile && !AtSpecialTag)
{
// Start a Block tag. This is used to wrap things like <p> or <a class="btn"> etc.
tagBlock = Context.StartBlock(BlockType.Tag);
}

// Handle unfinished tags that lie at the end of the file.
if (EndOfFile)
{
EndTagBlock(tags, complete: true);
Expand All @@ -133,34 +146,55 @@ private void TagBlock(Stack<Tuple<HtmlSymbol, SourceLocation>> tags)
{
_bufferedOpenAngle = null;
_lastTagStart = CurrentLocation;

Assert(HtmlSymbolType.OpenAngle);

_bufferedOpenAngle = CurrentSymbol;
SourceLocation tagStart = CurrentLocation;

var tagStart = CurrentLocation;
if (!NextToken())
{
Accept(_bufferedOpenAngle);
EndTagBlock(tags, complete: false);
}
else
{
complete = AfterTagStart(tagStart, tags);
complete = AfterTagStart(tagStart, tags, tagBlock);
}
}

if (complete)
{
// End tags have no accepted characters
Span.EditHandler.AcceptedCharacters = AcceptedCharacters.None;
}

// Output the contents of the tag into its own markup span.
Output(SpanKind.Markup);

// Will be null if we were at end of file or special tag when initially created.
if (tagBlock != null)
{
// End tag block
tagBlock.Dispose();
}
}
while (tags.Count > 0);

EndTagBlock(tags, complete);
}

private bool AfterTagStart(SourceLocation tagStart, Stack<Tuple<HtmlSymbol, SourceLocation>> tags)
private bool AfterTagStart(SourceLocation tagStart,
Stack<Tuple<HtmlSymbol, SourceLocation>> tags,
IDisposable tagBlockWrapper)
{
if (!EndOfFile)
{
switch (CurrentSymbol.Type)
{
case HtmlSymbolType.Solidus:
// End Tag
return EndTag(tagStart, tags);
return EndTag(tagStart, tags, tagBlockWrapper);
case HtmlSymbolType.Bang:
// Comment
Accept(_bufferedOpenAngle);
Expand All @@ -171,7 +205,7 @@ private bool AfterTagStart(SourceLocation tagStart, Stack<Tuple<HtmlSymbol, Sour
return XmlPI();
default:
// Start Tag
return StartTag(tags);
return StartTag(tags, tagBlockWrapper);
}
}
if (tags.Count == 0)
Expand Down Expand Up @@ -234,7 +268,9 @@ private bool CData()
return false;
}

private bool EndTag(SourceLocation tagStart, Stack<Tuple<HtmlSymbol, SourceLocation>> tags)
private bool EndTag(SourceLocation tagStart,
Stack<Tuple<HtmlSymbol, SourceLocation>> tags,
IDisposable tagBlockWrapper)
{
// Accept "/" and move next
Assert(HtmlSymbolType.Solidus);
Expand All @@ -258,8 +294,7 @@ private bool EndTag(SourceLocation tagStart, Stack<Tuple<HtmlSymbol, SourceLocat
String.Equals(tagName, SyntaxConstants.TextTagName, StringComparison.OrdinalIgnoreCase) &&
matched)
{
Output(SpanKind.Markup);
return EndTextTag(solidus);
return EndTextTag(solidus, tagBlockWrapper);
}
Accept(_bufferedOpenAngle);
Accept(solidus);
Expand All @@ -271,7 +306,17 @@ private bool EndTag(SourceLocation tagStart, Stack<Tuple<HtmlSymbol, SourceLocat
}
}

private bool EndTextTag(HtmlSymbol solidus)
private void RecoverTextTag()
{
// We don't want to skip-to and parse because there shouldn't be anything in the body of text tags.
AcceptUntil(HtmlSymbolType.CloseAngle, HtmlSymbolType.NewLine);

// Include the close angle in the text tag block if it's there, otherwise
// just move on
Optional(HtmlSymbolType.CloseAngle);
}

private bool EndTextTag(HtmlSymbol solidus, IDisposable tagBlockWrapper)
{
SourceLocation start = _bufferedOpenAngle.Start;

Expand All @@ -286,6 +331,9 @@ private bool EndTextTag(HtmlSymbol solidus)
if (!seenCloseAngle)
{
Context.OnError(start, RazorResources.ParseError_TextTagCannotContainAttributes);

Span.EditHandler.AcceptedCharacters = AcceptedCharacters.Any;
RecoverTextTag();
}
else
{
Expand All @@ -294,9 +342,22 @@ private bool EndTextTag(HtmlSymbol solidus)

Span.CodeGenerator = SpanCodeGenerator.Null;
Output(SpanKind.Transition);

tagBlockWrapper.Dispose();

return seenCloseAngle;
}

private bool AtSpecialTag
{
get
{
return (At(HtmlSymbolType.OpenAngle) &&
(NextIs(HtmlSymbolType.Bang) ||
NextIs(HtmlSymbolType.QuestionMark)));
}
}

private bool IsTagRecoveryStopPoint(HtmlSymbol sym)
{
return sym.Type == HtmlSymbolType.CloseAngle ||
Expand Down Expand Up @@ -489,11 +550,11 @@ private void AttributeValue(HtmlSymbolType quote)
// Literal value
// 'quote' should be "Unknown" if not quoted and symbols coming from the tokenizer should never have "Unknown" type.
var value = ReadWhile(sym =>
// These three conditions find separators which break the attribute value into portions
// These three conditions find separators which break the attribute value into portions
sym.Type != HtmlSymbolType.WhiteSpace &&
sym.Type != HtmlSymbolType.NewLine &&
sym.Type != HtmlSymbolType.Transition &&
// This condition checks for the end of the attribute value (it repeats some of the checks above but for now that's ok)
// This condition checks for the end of the attribute value (it repeats some of the checks above but for now that's ok)
!IsEndOfAttributeValue(quote, sym));
Accept(value);
Span.CodeGenerator = new LiteralAttributeCodeGenerator(prefix.GetContent(prefixStart), value.GetContent(prefixStart));
Expand Down Expand Up @@ -583,7 +644,7 @@ private void ParseQuoted(HtmlSymbolType type)
}
}

private bool StartTag(Stack<Tuple<HtmlSymbol, SourceLocation>> tags)
private bool StartTag(Stack<Tuple<HtmlSymbol, SourceLocation>> tags, IDisposable tagBlockWrapper)
{
// If we're at text, it's the name, otherwise the name is ""
HtmlSymbol tagName;
Expand Down Expand Up @@ -625,6 +686,8 @@ private bool StartTag(Stack<Tuple<HtmlSymbol, SourceLocation>> tags)
Context.Source.Position = bookmark;
NextToken();
Context.OnError(tag.Item2, RazorResources.ParseError_TextTagCannotContainAttributes);

RecoverTextTag();
}
else
{
Expand All @@ -637,14 +700,20 @@ private bool StartTag(Stack<Tuple<HtmlSymbol, SourceLocation>> tags)
tags.Push(tag);
}
Output(SpanKind.Transition);

// Close out the tag block around the contents of the "text" tag
tagBlockWrapper.Dispose();

return true;
}
Accept(_bufferedOpenAngle);
Optional(HtmlSymbolType.Text);
return RestOfTag(tag, tags);
return RestOfTag(tag, tags, tagBlockWrapper);
}

private bool RestOfTag(Tuple<HtmlSymbol, SourceLocation> tag, Stack<Tuple<HtmlSymbol, SourceLocation>> tags)
private bool RestOfTag(Tuple<HtmlSymbol, SourceLocation> tag,
Stack<Tuple<HtmlSymbol, SourceLocation>> tags,
IDisposable tagBlockWrapper)
{
TagContent();

Expand Down Expand Up @@ -676,6 +745,10 @@ private bool RestOfTag(Tuple<HtmlSymbol, SourceLocation> tag, Stack<Tuple<HtmlSy
string tagName = tag.Item1.Content.Trim();
if (VoidElements.Contains(tagName))
{
Span.EditHandler.AcceptedCharacters = AcceptedCharacters.None;
Output(SpanKind.Markup);
tagBlockWrapper.Dispose();

// Technically, void elements like "meta" are not allowed to have end tags. Just in case they do,
// we need to look ahead at the next set of tokens. If we see "<", "/", tag name, accept it and the ">" following it
// Place a bookmark
Expand All @@ -692,28 +765,49 @@ private bool RestOfTag(Tuple<HtmlSymbol, SourceLocation> tag, Stack<Tuple<HtmlSy
Assert(HtmlSymbolType.Solidus);
HtmlSymbol solidus = CurrentSymbol;
NextToken();
if (At(HtmlSymbolType.Text) && String.Equals(CurrentSymbol.Content, tagName, StringComparison.OrdinalIgnoreCase))
if (At(HtmlSymbolType.Text) && string.Equals(CurrentSymbol.Content, tagName, StringComparison.OrdinalIgnoreCase))
{
// Accept up to here
Accept(ws);
Accept(openAngle);
Accept(solidus);
AcceptAndMoveNext();
Output(SpanKind.Markup); // Output the whitespace

bool complete;

using (Context.StartBlock(BlockType.Tag))
{
Accept(openAngle);
Accept(solidus);
AcceptAndMoveNext();

// Accept to '>', '<' or EOF
AcceptUntil(HtmlSymbolType.CloseAngle, HtmlSymbolType.OpenAngle);
// Accept the '>' if we saw it. And if we do see it, we're complete
return Optional(HtmlSymbolType.CloseAngle);
} // At(HtmlSymbolType.Text) && String.Equals(CurrentSymbol.Content, tagName, StringComparison.OrdinalIgnoreCase)
} // At(HtmlSymbolType.OpenAngle) && NextIs(HtmlSymbolType.Solidus)
// Accept to '>', '<' or EOF
AcceptUntil(HtmlSymbolType.CloseAngle, HtmlSymbolType.OpenAngle);
// Accept the '>' if we saw it. And if we do see it, we're complete
complete = Optional(HtmlSymbolType.CloseAngle);

if (complete)
{
Span.EditHandler.AcceptedCharacters = AcceptedCharacters.None;
}

// Output the closing void element
Output(SpanKind.Markup);
}

return complete;
}
}

// Go back to the bookmark and just finish this tag at the close angle
Context.Source.Position = bookmark;
NextToken();
}
else if (String.Equals(tagName, "script", StringComparison.OrdinalIgnoreCase))
{
SkipToEndScriptAndParseCode();
Span.EditHandler.AcceptedCharacters = AcceptedCharacters.None;
Output(SpanKind.Markup);
tagBlockWrapper.Dispose();

SkipToEndScriptAndParseCode(endTagAcceptedCharacters: AcceptedCharacters.None);
}
else
{
Expand All @@ -725,30 +819,56 @@ private bool RestOfTag(Tuple<HtmlSymbol, SourceLocation> tag, Stack<Tuple<HtmlSy
return seenClose;
}

private void SkipToEndScriptAndParseCode()
private void SkipToEndScriptAndParseCode(AcceptedCharacters endTagAcceptedCharacters = AcceptedCharacters.Any)
{
// Special case for <script>: Skip to end of script tag and parse code
bool seenEndScript = false;

while (!seenEndScript && !EndOfFile)
{
SkipToAndParseCode(HtmlSymbolType.OpenAngle);
SourceLocation tagStart = CurrentLocation;
AcceptAndMoveNext();
AcceptWhile(HtmlSymbolType.WhiteSpace);
if (Optional(HtmlSymbolType.Solidus))

if (NextIs(HtmlSymbolType.Solidus))
{
AcceptWhile(HtmlSymbolType.WhiteSpace);
if (At(HtmlSymbolType.Text) && String.Equals(CurrentSymbol.Content, "script", StringComparison.OrdinalIgnoreCase))
var openAngle = CurrentSymbol;
NextToken(); // Skip over '<', current is '/'
var solidus = CurrentSymbol;
NextToken(); // Skip over '/', current should be text

if (At(HtmlSymbolType.Text) && string.Equals(CurrentSymbol.Content, "script", StringComparison.OrdinalIgnoreCase))
{
// </script!
seenEndScript = true;
}

PutCurrentBack(); // Put back whatever was after the solidus

PutBack(solidus); // Put back '/'
PutBack(openAngle); // Put back '<'
}

if(seenEndScript)
{
Output(SpanKind.Markup);

using (Context.StartBlock(BlockType.Tag))
{
Span.EditHandler.AcceptedCharacters = endTagAcceptedCharacters;

AcceptAndMoveNext(); // '<'
AcceptAndMoveNext(); // '/'
SkipToAndParseCode(HtmlSymbolType.CloseAngle);
if (!Optional(HtmlSymbolType.CloseAngle))
{
Context.OnError(tagStart, RazorResources.FormatParseError_UnfinishedTag("script"));
}
seenEndScript = true;
Output(SpanKind.Markup);
}
}
else
{
AcceptAndMoveNext(); // '<' (not the closing script tags open angle)
}
}
}

Expand Down
Loading

0 comments on commit 3767597

Please sign in to comment.