Consider removing IApplicationEnvironment \ IRuntimeEnvironment

[pranavkm]

• Runtime components in Asp.Net have switched to using IHostingEnvironment over IApplicationEnvironment.
• CoreFX has a RuntimeInformation type that has most of the API that IRuntimeEnvironment supports.

Given these, we could remove these types from our codebase. We can follow up with a change to the CLI so that it removes one arc of the cyclic dependency that is currently present between the two.

cc @davidfowl \ @Eilon

[pranavkm]

Related to #34

[natemcmaster]

Is this also going into RC2?

[analogrelay]

Is the goal here to remove the interfaces, or the implementations as well? We are definitely using the implementations in a number of places (and RuntimeInformation is not sufficient to cover those)

[pranavkm]

@anurse - the implementations will stay. Here's the PR for it #39

[analogrelay]

Yeah, I saw the PR and it looked OK. I was just concerned there was going to be a part 2 that removed the implementations :P

[pranavkm]

The hope was to move the RID inference code into Cli and switch to using RuntimeInformation in our code. Part of a set of changes to unbreak cycles between CLI and our repos.

[Eilon]

@pranavkm any further work for this?

[pranavkm]

Needs to be checked in. Waiting for the new CLI to do this.

[Eilon]

Ah ok!

[pranavkm]

Fixed in 95d352a

[Eilon]

Done/Closed/Open?

[DavidArno]

Can anyone explain the logic behind removing these interfaces? This has just made testing harder for no logical reason that I can see.

[pranavkm]

@DavidArno - we no longer use these interfaces in our codebases. In the past, DNX owned creating \ populating \ injecting these interfaces. However since the move to CLI, these are primarily wrappers for System.Runtime.InteropServices.RuntimeInformation and AppContext.BaseDirectory \ AppDomain.BaseDirectory. We didn't find it necessary to continue maintaining abstractions for wrappers.

We do have an IHostingEnvironment interface which has abstractions for web related things such as content root and web root which is what all our middlewares use.