This repository was archived by the owner on Dec 14, 2018. It is now read-only.
Mitigate MediaType overflow #5677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rynowak
reviewed
Jan 11, 2017
| { | ||
| throw new ArgumentOutOfRangeException(nameof(length)); | ||
| } | ||
|
|
||
| if (offset > mediaType.Length - length) | ||
| { | ||
| // TODO: This isn't necessarily length's fault but changing this to an ArgumentException with the |
ryanbrandenburg
force-pushed
the
rybrande/MediaTypeOverflow
branch
from
04d4384 to
3fb2e10
Compare
|
🆙📅 |
rynowak
reviewed
Jan 12, 2017
| @@ -387,4 +387,7 @@ | |||
| <value>Unable to create an instance of type '{0}'. The type specified in {1} must not be abstract and must have a parameterless constructor.</value> | |||
| <comment>0 is the type to configure. 1 is the name of the parameter, configurationType.</comment> | |||
| </data> | |||
| <data name="Argument_InvalidOffsetLength" xml:space="preserve"> | |||
| <value>Offset and length are out of bounds for the string or length is greater than the number of characters from index to the end of the string.</value> | |||
There was a problem hiding this comment.
You should pass in the names of the parameters and surround them with single quotes. Don't put "code names" in resources because they should not be translated.
|
🆙📅 |
rynowak
reviewed
Jan 13, 2017
| @@ -387,4 +387,8 @@ | |||
| <value>Unable to create an instance of type '{0}'. The type specified in {1} must not be abstract and must have a parameterless constructor.</value> | |||
| <comment>0 is the type to configure. 1 is the name of the parameter, configurationType.</comment> | |||
| </data> | |||
| <data name="Argument_InvalidOffsetLength" xml:space="preserve"> | |||
| <value>{0} and {1} are out of bounds for the string.</value> | |||
There was a problem hiding this comment.
put single quotes around the parameters to make it clear that you're referring to the parameter by name.
rynowak
approved these changes
Jan 13, 2017
ryanbrandenburg
force-pushed
the
rybrande/MediaTypeOverflow
branch
from
a4604d9 to
76a1a46
Compare
ryanbrandenburg
force-pushed
the
rybrande/MediaTypeOverflow
branch
from
76a1a46 to
93774a0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5560 in the same way as e7a24a1f8.