This repository was archived by the owner on Dec 14, 2018. It is now read-only.
Add more to MvcCoreServiceCollectionExtensionsTest
#5564
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eilon
suggested changes
Nov 24, 2016
| { | ||
| // Arrange | ||
| var services = new ServiceCollection(); | ||
| var mockManager = new Mock<ApplicationPartManager>(MockBehavior.Strict); |
There was a problem hiding this comment.
Why do so many mocks have to be added? Would it be enough to add 1 fake one, then 1 real one, and assert that the 1 real one (which was last) was retrieved?
There was a problem hiding this comment.
Decided to test 1 and 3 rather than 1 and 2. Either is fine and I'll remove the two extra lines in two tests.
|
To answer the main question: yes, this is pretty much what I had in mind! |
|
🆙📅 |
Eilon
approved these changes
Nov 26, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes @danroth27's changes from #5540 but I've rebased his commit. Ignore that bit.