This repository was archived by the owner on Dec 14, 2018. It is now read-only.
AttributeRoute does not replace existing route values with null #3038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Assert.Equal("Bar", context.RouteData.Values["path"]); | ||
| } | ||
|
|
||
| [Fact] |
There was a problem hiding this comment.
Not super familiar with routing code, but is it possible for the router to route without visiting the entry (and consequently invoke MergeAttributes?)
There was a problem hiding this comment.
Routing creates a defensive copy at each level so that changes that aren't persisted don't dirty something else on the fallback path. That's what's on the whiteboard next to you, you silly goose! 🐐
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2931
@rynowak @pranavkm