Add srcset to list of application relative resolvable URLs.
#2970
Conversation
|
/cc @ajaybhargavb @dougbu |
| <track src="/email~/SomeUrl"> | ||
| </audio> | ||
| <embed src="/email@dyanmicUrl"> | ||
| <iframe src="/SomeUrl" /> | ||
| <img src="/~/SomeUrl"> | ||
| <img src="/~/SomeUrl" srcset="/~/SomeUrl"> |
There was a problem hiding this comment.
Huh? Why is the ~ character not replaced here?
There was a problem hiding this comment.
Realize it's an existing issue but this looks all kind of wrong.
There was a problem hiding this comment.
It's not. The original source evaluated is: <img src="~/~/SomeUrl" srcset="~/~/SomeUrl">
There was a problem hiding this comment.
Suggest two variables e.g. tildePath and relativePath to avoid this invalidity. Would still be testing the different code paths but without veering into something no user would do.
There was a problem hiding this comment.
👎
It's a functional test. We're purposefully doing things that user code wouldn't normally do; this file tries to do everything known to man for variations of ~/ 😄.
|
⌚ |
NTaylorMullen
force-pushed
the
nimullen/srcset.2964
branch
from
4369922 to
b2125cb
Compare
|
Updated. |
| <track src="~/email@(dynamicUrl)"> | ||
| </audio> | ||
| <embed src="~/email@dyanmicUrl"> | ||
| <iframe src=@(dynamicUrl) /> | ||
| <img src="~/@dynamicUrl"> | ||
| <img src="~/@Model.Name" srcset="~/@Model.Name"> |
|
|
NTaylorMullen
force-pushed
the
nimullen/srcset.2964
branch
from
b2125cb to
069395f
Compare
- Now allow the attribute to exist on `img` and `source` tags. - Updated existing `UrlResolutionTagHelper` functional test to validate `srcset` attribute. #2964
NTaylorMullen
force-pushed
the
nimullen/srcset.2964
branch
from
069395f to
e73e73a
Compare
imgandsourcetags.UrlResolutionTagHelperfunctional test to validatesrcsetattribute.srcset missing from ~ tag helper. #2964