This repository was archived by the owner on Dec 14, 2018. It is now read-only.
TagHelpers attribute targeting - part 1 #2211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
| // IHtmlGenerator will enforce name requirements. | ||
| var metadata = For.Metadata; | ||
| var modelExplorer = For.ModelExplorer; | ||
| if (metadata == null) |
There was a problem hiding this comment.
There seem to be more changes going on here than just the attribute targeting, whatsis?
There was a problem hiding this comment.
This was previous code, the diff is just misleading. Since we require the asp-for attribute to be provided there was no longer a need to check if it was provided.
|
solid, |
ajaybhargavb
force-pushed
the
taghelper-attribute
branch
from
c09791b to
6624088
Compare
|
|
| /// attribute. | ||
| /// </summary> | ||
| [TargetElement("span")] | ||
| [TargetElement(Attributes = ValidationForAttributeName)] |
There was a problem hiding this comment.
this change in behaviour should be separate. discuss w/ @DamianEdwards as to whether we need to make this change.
|
⌚ doesn't look ready |
ajaybhargavb
force-pushed
the
taghelper-attribute
branch
from
6624088 to
525c1cf
Compare
|
Created a follow up issue #2220 |
ajaybhargavb
force-pushed
the
taghelper-attribute
branch
from
525c1cf to
bfdeda7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #2195
@NTaylorMullen @dougbu