This repository was archived by the owner on Dec 14, 2018. It is now read-only.
* Introduce _GlobalImports to inherit directives. #2020
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
| namespace Microsoft.AspNet.Mvc.Razor | ||
| { | ||
| /// <summary> | ||
| /// Contains methods to locate <c>_ViewStart.cshtml</c> and <c>_Global.cshtml</c> |
There was a problem hiding this comment.
_GlobalImpot.cshtml
|
Pretty much there, ⌚ |
* Remove inheritance from _ViewStarts Fixes #825
pranavkm
force-pushed
the
Global.cshtml
branch
from
af92ca1 to
25ad56d
Compare
pranavkm
force-pushed
the
Global.cshtml
branch
from
25ad56d to
e8a5ce1
Compare
|
Updated. |
| @@ -126,20 +124,33 @@ public class PrecompilationTest | |||
| Assert.NotEqual(response6.Layout, response7.Layout); | |||
|
|
|||
| // Act - 8 | |||
| // Refetch and verify we get cached types | |||
| // Remove new _ViewStart file | |||
|
Looks good to me |
|
Just for anyone that's come across this thread or #881, the new way is to have a file called: _GlobalImport.cshtml (no 's' on the end) to 'globally' inject services into views which can exist at any view folder hierarchy or so it seems. |
|
To add to what @Shazwazza wrote above - this also seems to support the @inherits directive. So, you can derive your views from a base class globally without having to put @inherits at the top of each view. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #825