Skip to content
This repository was archived by the owner on Dec 14, 2018. It is now read-only.

Changes to show intellisense for @inject directive #1147

Closed
wants to merge 3 commits into from
Closed

Conversation

pranavkm
Copy link
Contributor

@yishaigalatzer
Copy link
Contributor

Code change looks good, missing a test to make sure the right inject pattern in generated.

@NTaylorMullen
Copy link
Contributor

  1. Add a line mapping test for partially written @inject code, something like:
    https://github.com/aspnet/Razor/blob/dev/test/Microsoft.AspNet.Razor.Test/Generator/CSharpRazorCodeGeneratorTest.cs#L122-L134
  2. Add a syntax tree test to validate that the correct inject syntax tree is generated for the partially written inject case (if we don't have one for the fully written case we should add that). Something like: https://github.com/aspnet/Razor/blob/dev/test/Microsoft.AspNet.Razor.Test/Parser/CSharp/CSharpDirectivesTest.cs#L16-L24 but for the partial case

@NTaylorMullen
Copy link
Contributor

🚢 🇮🇹

@pranavkm pranavkm closed this Sep 17, 2014
@pranavkm pranavkm deleted the Inject branch September 17, 2014 19:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants