Attribute Routing: Add ability to specify route info to Http*Attributes #730

rynowak · 2014-07-01T16:02:54Z

We need to add the routing members to our Http*Attributes (Ex: [HttpGet("api/Products", Order = 1, Name = "Products")]. This will allow using [HttpGet(...)] and friends to specify an attribute route.

Needs to include: Route, Name, Order

The text was updated successfully, but these errors were encountered:

Added properties for order, name, constraints, default values and data tokens to IRouteTemplateProvider and implementations on all the Http*Attributes. Name and order are settable in those implementations, constraints, default values and data tokens have a default virtual implementation that returns null. This change also unseals the Http*Attributes so that they can be extended and customized. Added unit tests to validate the implementations for the IActionHttpMethodProvider and IRouteTemplateProvider in the framework. Added functional tests to cover extra attribute routing scenarios like a test for an action with an HttpDeleteAttribute on it and action with AcceptVerbsAttribute and an action with a custom HttpMergeAttribute implemented.

1. Added a new AttributeRouteInfo class to store all the information for actions that are attribute routed. 2. Refactored ActionDescriptor, ReflectedControllerModel and ReflectedActionModel to use AttributeRouteInfo instead of just the attribute route template. 3. Added a CombineAttributeRouteInfo method in AttributeRouteTemplate that handles combining two AttributeRouteInfo instances. 4. Refactored ReflectedActionDescriptorProvider to use AttributeRouteInfo instead of the attribute route template. 5. Added unit tests for ReflectedActionModel and ReflectedControllerModel that cover the usage of AttributeRouteInfo. 6. Added unit tests for CombineAttributeRouteInfo.

1. Unsealed the Http*Attributes so that they can be extended and customized. 2. Added the same constructors as HttpGet to the rest of the Http*Attributes. 3. Added unit tests to validate the implementations for the IActionHttpMethodProvider. 4. Added functional tests to cover extra attribute routing scenarios like a test for an action with an HttpDeleteAttribute on it and action with AcceptVerbsAttribute and an action with a custom HttpMergeAttribute implemented.

1. Added a new AttributeRouteInfo class to store all the information for actions that are attribute routed. 2. Added a new ReflectedAttributeRouteModel class to store all the information related to attribute routes in the ReflectedApplicationModel. 3. Refactored ReflectedControllerModel and ReflectedActionModel to use ReflectedAttributeRouteModel instead of just the attribute route template. 4. Refactored ReflectedActionDescriptorProvider to use AttributeRouteInfo and ReflectedAttributeRouteModel instead of just the route template. 5. Added a CombineReflectedAttributeRouteModel method in ReflectedAttributeRouteModel that handles combining two ReflectedAttributeRouteModel instances. 6. Removed the AttributeRouteTemplate class and moved the methods for combining attribute routes to the ReflectedAttributeRouteModel class. 7. Added unit tests for ReflectedActionModel and ReflectedControllerModel that cover the usage of AttributeRouteInfo. 8. Added unit tests for CombineReflectedAttributeRouteModel.

javiercn · 2014-07-28T22:49:08Z

See #733 #734 #45

1. Added a new AttributeRouteInfo class to store all the information for actions that are attribute routed. 2. Added a new ReflectedAttributeRouteModel class to store all the information related to attribute routes in the ReflectedApplicationModel. 3. Refactored ReflectedControllerModel and ReflectedActionModel to use ReflectedAttributeRouteModel instead of just the attribute route template. 4. Refactored ReflectedActionDescriptorProvider to use AttributeRouteInfo and ReflectedAttributeRouteModel instead of just the route template. 5. Added a CombineReflectedAttributeRouteModel method in ReflectedAttributeRouteModel that handles combining two ReflectedAttributeRouteModel instances. 6. Removed the AttributeRouteTemplate class and moved the methods for combining attribute routes to the ReflectedAttributeRouteModel class. 7. Added unit tests for ReflectedActionModel and ReflectedControllerModel that cover the usage of AttributeRouteInfo. 8. Added unit tests for CombineReflectedAttributeRouteModel.

1. Unsealed the Http*Attributes so that they can be extended and customized. 2. Added the same constructors as HttpGet to the rest of the Http*Attributes. 3. Added unit tests to validate the implementations for the IActionHttpMethodProvider. 4. Added functional tests to cover extra attribute routing scenarios like a test for an action with an HttpDeleteAttribute on it and action with AcceptVerbsAttribute and an action with a custom HttpMergeAttribute implemented.

1. Added a new AttributeRouteInfo class to store all the information for actions that are attribute routed. 2. Added a new ReflectedAttributeRouteModel class to store all the information related to attribute routes in the ReflectedApplicationModel. 3. Refactored ReflectedControllerModel and ReflectedActionModel to use ReflectedAttributeRouteModel instead of just the attribute route template. 4. Refactored ReflectedActionDescriptorProvider to use AttributeRouteInfo and ReflectedAttributeRouteModel instead of just the route template. 5. Added a CombineReflectedAttributeRouteModel method in ReflectedAttributeRouteModel that handles combining two ReflectedAttributeRouteModel instances. 6. Removed the AttributeRouteTemplate class and moved the methods for combining attribute routes to the ReflectedAttributeRouteModel class. 7. Added unit tests for ReflectedActionModel and ReflectedControllerModel that cover the usage of AttributeRouteInfo. 8. Added unit tests for CombineReflectedAttributeRouteModel.

1. Unsealed the Http*Attributes so that they can be extended and customized. 2. Added the same constructors as HttpGet to the rest of the Http*Attributes. 3. Added unit tests to validate the implementations for the IActionHttpMethodProvider. 4. Added functional tests to cover extra attribute routing scenarios like a test for an action with an HttpDeleteAttribute on it and action with AcceptVerbsAttribute and an action with a custom HttpMergeAttribute implemented.

1. Added a new AttributeRouteInfo class to store all the information for actions that are attribute routed. 2. Added a new ReflectedAttributeRouteModel class to store all the information related to attribute routes in the ReflectedApplicationModel. 3. Refactored ReflectedControllerModel and ReflectedActionModel to use ReflectedAttributeRouteModel instead of just the attribute route template. 4. Refactored ReflectedActionDescriptorProvider to use AttributeRouteInfo and ReflectedAttributeRouteModel instead of just the route template. 5. Added a CombineReflectedAttributeRouteModel method in ReflectedAttributeRouteModel that handles combining two ReflectedAttributeRouteModel instances. 6. Removed the AttributeRouteTemplate class and moved the methods for combining attribute routes to the ReflectedAttributeRouteModel class. 7. Added unit tests for ReflectedActionModel and ReflectedControllerModel that cover the usage of AttributeRouteInfo. 8. Added unit tests for CombineReflectedAttributeRouteModel.

1. Unsealed the Http*Attributes so that they can be extended and customized. 2. Added the same constructors as HttpGet to the rest of the Http*Attributes. 3. Added unit tests to validate the implementations for the IActionHttpMethodProvider. 4. Added functional tests to cover extra attribute routing scenarios like a test for an action with an HttpDeleteAttribute on it and action with AcceptVerbsAttribute and an action with a custom HttpMergeAttribute implemented. Conflicts: test/Microsoft.AspNet.Mvc.Core.Test/Microsoft.AspNet.Mvc.Core.Test.kproj