Skip to content
This repository was archived by the owner on Dec 14, 2018. It is now read-only.

Remove legacy / non-unobtrusive client side validation #620

Closed
pranavkm opened this issue Jun 5, 2014 · 3 comments
Closed

Remove legacy / non-unobtrusive client side validation #620

pranavkm opened this issue Jun 5, 2014 · 3 comments
Assignees
Milestone

Comments

@pranavkm
Copy link
Contributor

pranavkm commented Jun 5, 2014

Mvc5 supported a non-unobtrusive way for performing client side validation. This was triggered when you set htmlhelper.unobtrusivejavascriptenabled to false. We need to figure out if we are still interested in supporting this ability going forward

@dougbu
Copy link
Member

dougbu commented Jul 24, 2014

/cc @danroth27 @DamianEdwards this is a top-level question we need to answer in this milestone.

Sub-items such as #163, #435, and #449 would not be necessary if we decide only Unobtrusive validation (and the hooks to override the specific attributes generated) is necessary. Should also look at whether we need all FormContext properties should that be our choice. On the other hand, may need extensibility points allowing other non-Unobtrusive JavaScript to be included in or around a <form/> -- not just overriding the Unobtrusive attributes where we currently generate them.

@dougbu dougbu changed the title Client side validation Revive legacy / non-unobtrusive client side validation? Jul 24, 2014
@dougbu
Copy link
Member

dougbu commented Jul 25, 2014

Decision is to remove the legacy (non-Unobtrusive) client-side validation feature from MVC 6.0. Current MVC 6.0 implementation is incomplete and our efforts are better spent on core scenarios. Similar feature in MVC 5.2 is likely very little-used since it relies on a JavaScript package that isn't even in NuGet.

Therefore the ask here is to remove ViewContext.UnobtrusiveJavaScriptEnabled and anything relying on that property.

@dougbu dougbu changed the title Revive legacy / non-unobtrusive client side validation? Remove legacy / non-unobtrusive client side validation Jul 25, 2014
dougbu added a commit that referenced this issue Jul 25, 2014
- remove `ViewContext.UnobtrusiveJavaScriptEnabled` property and all references
- also avoid `ViewContext.GetFormContextForClientValidation()` calls since
  ternary expression is more explicit and we were inconsistent
dougbu added a commit that referenced this issue Jul 25, 2014
- remove `ViewContext.UnobtrusiveJavaScriptEnabled` property and all references
- also avoid `ViewContext.GetFormContextForClientValidation()` calls since
  ternary expression is more explicit and we were inconsistent
@dougbu dougbu closed this as completed in b5dcc98 Jul 29, 2014
@dougbu
Copy link
Member

dougbu commented Jul 29, 2014

Fixed in commits b5dcc98 and 43d1253.

@dougbu dougbu modified the milestones: 6.0.0-beta1, 6.0.0-alpha3 Aug 6, 2014
@danroth27 danroth27 added the bug label Aug 17, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants