Skip to content
This repository was archived by the owner on Dec 14, 2018. It is now read-only.

Tag helpers lose user's case for class attribute when merging a TagBuilder #5313

Closed
dougbu opened this issue Sep 23, 2016 · 1 comment
Closed

Tag helpers lose user's case for class attribute when merging a TagBuilder #5313

dougbu opened this issue Sep 23, 2016 · 1 comment
Assignees
@dougbu
Labels
3 - Done bug
Milestone
1.1.0-preview1

Comments

@dougbu
Copy link
Member

dougbu commented Sep 23, 2016

E.g.

<input Class="single-line" asp-for="property" />

results in

<input class="single-line" type="text" ... />

Fix is a very simple change to TagHelperOutputExtensions.

Self-assigning because I fixed this while making other changes...
@dougbu dougbu added this to the 1.1.0 milestone Sep 23, 2016
@dougbu dougbu self-assigned this Sep 23, 2016
dougbu added a commit that referenced this issue Sep 23, 2016
@dougbu
Preserve class casing when merging a TagBuilder into a `TagHelper…
e7e12f0 
…Output`

- #5313
@dougbu dougbu mentioned this issue Sep 23, 2016
Closed
dougbu added a commit that referenced this issue Sep 24, 2016
@dougbu
Preserve class casing when merging a TagBuilder into a `TagHelper…
235447d 
…Output`

- #5313
dougbu added a commit that referenced this issue Sep 26, 2016
@dougbu
Preserve class casing when merging a TagBuilder into a `TagHelper…
27e4822 
…Output`

- #5313

Also:
- preserve existing `TagHelperAttribute.ValueStyle`
 - fix this in `UrlResolutionTagHelper`, `LinkTagHelper`, and `ScriptTagHelper` as well
- correct handling of non-`string` `classAttribute.Value`s in `TagHelperOutputExtensions`
 - relates to #3918 because new `ClassAttributeHtmlContent` is smaller than any concatenated attribute value

nit: clean up `CacheTagHelper` whitespace and `using`s
@dougbu
Copy link
Member Author

dougbu commented Sep 26, 2016

27e4822

@dougbu dougbu closed this as completed Sep 26, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dougbu dougbu

Labels
3 - Done bug
Projects
None yet
Milestone
1.1.0-preview1
Development

No branches or pull requests
1 participant
@dougbu