Skip to content
This repository was archived by the owner on Dec 14, 2018. It is now read-only.

Remove ValueProviderResultExtensions #5063

Closed
dougbu opened this issue Jul 22, 2016 · 2 comments
Closed

Remove ValueProviderResultExtensions #5063

dougbu opened this issue Jul 22, 2016 · 2 comments
Assignees
@dougbu
Labels
3 - Done breaking-change
Milestone
2.0.0-preview1

Comments

@dougbu
Copy link
Member

dougbu commented Jul 22, 2016

Obsoleted Microsoft.AspNetCore.Mvc.ModelBinding.ValueProviderResultExtensions in 1.1.0 (49a48a0). Removing it completes work related to #4521.

Removing these extension methods may allow further slimming or division of the ModelBindingHelper.ConvertTo() methods. In particular, should no longer need conversions to arbitrary types, just from arbitrary types to string, string[] and bool. See #4521 for details on this.
@dougbu dougbu added this to the 2.0.0 milestone Jul 22, 2016
@Eilon Eilon modified the milestones: 2.0.0, 1.2.0 Dec 19, 2016
@dougbu
Copy link
Member Author

dougbu commented Mar 7, 2017

Blocked by aspnet/KoreBuild#143. Need to confirm Mvc remains ready for API-check's restoration.

dougbu added a commit that referenced this issue Mar 26, 2017
@dougbu
Remove ValueProviderResultExtensions
824d65c 
- #5063
- update tests that used one extension method to instead use `ModelBindingHelper` directly

nit: `mbc` -> `context`
@dougbu dougbu mentioned this issue Mar 26, 2017
Merged
@dougbu
Copy link
Member Author

dougbu commented Mar 27, 2017

824d65c

@dougbu dougbu closed this as completed Mar 27, 2017
@Eilon Eilon mentioned this issue Jul 28, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dougbu dougbu

Labels
3 - Done breaking-change
Projects
None yet
Milestone
2.0.0-preview1
Development

No branches or pull requests
2 participants
@Eilon @dougbu