Skip to content
This repository was archived by the owner on Dec 14, 2018. It is now read-only.

MapAreaRoute override existing area constraint #4847

Closed
sebastienros opened this issue Jun 10, 2016 · 7 comments
Closed

MapAreaRoute override existing area constraint #4847

sebastienros opened this issue Jun 10, 2016 · 7 comments
Assignees
@ajaybhargavb
Labels
3 - Done bug up-for-grabs Members of our awesome commnity can handle this issue
Milestone
1.1.0-preview1

Comments

@sebastienros
Copy link
Member

sebastienros commented Jun 10, 2016 •
edited
Loading

When using MapAreaRoute with an existing set of constraints containing the area entry, the entry will be overriden by the area name passed as a parameter. I would expect it to be kept in this case.
For example, I want to pass an explicit constraint object for area instead of a string to prevent Regex comparisons on this route.
@Eilon Eilon added bug 1 - Ready up-for-grabs Members of our awesome commnity can handle this issue labels Jun 10, 2016
@Eilon Eilon added this to the 1.0.1 milestone Jun 10, 2016
@iscifoni
Copy link
Contributor

iscifoni commented Jul 1, 2016

@Eilon This is in up-for-grabs.. I can do it ?

@rynowak
Copy link
Member

rynowak commented Jul 1, 2016

I'm not @Eilon - but yes!

up-for-grabs means that we're definitely interested in a fix and it's also a good issue for someone unfamiliar with the code to take a crack at. Please do

@iscifoni
Copy link
Contributor

iscifoni commented Jul 1, 2016

ok Thanks :)

@Eilon
Copy link
Member

Eilon commented Jul 1, 2016

Yup, go for it!

@iscifoni iscifoni mentioned this issue Jul 4, 2016
Merged
@Eilon
Copy link
Member

Eilon commented Jul 7, 2016

@ajaybhargavb assigning this to you to track @iscifoni 's PR at #4954.

ajaybhargavb pushed a commit that referenced this issue Jul 11, 2016
@iscifoni @ajaybhargavb
#4847 Fix MapAreaRoute override existing area constraint (#4954)
b4677a4 
*  #4847 Fix MapAreaRoute override existing area constraint
Modify Test project
Modify web test routing

* wrong field tested

* IntRouteConstraint expected

* Default for area route on Travel area

* Removed commented code
simplify constraintsDictionary area assign
renamed test method

* test name

* renamedd test to MapAreaRoute_DoesNotReplaceValuesForAreaIfAlreadyPresentInConstraintsOrDefaults
@ajaybhargavb
Copy link
Contributor

b4677a4

@ajaybhargavb
Copy link
Contributor

Thanks! @iscifoni

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ajaybhargavb ajaybhargavb

Labels
3 - Done bug up-for-grabs Members of our awesome commnity can handle this issue
Projects
None yet
Milestone
1.1.0-preview1
Development

No branches or pull requests
5 participants
@Eilon @sebastienros @rynowak @ajaybhargavb @iscifoni