Skip to content
This repository was archived by the owner on Dec 14, 2018. It is now read-only.

Add tests covering more JSON serialization cases #4844

Closed
dougbu opened this issue Jun 9, 2016 · 2 comments
Closed

Add tests covering more JSON serialization cases #4844

dougbu opened this issue Jun 9, 2016 · 2 comments
Assignees
@dougbu
Labels
3 - Done Add Tests
Milestone
1.0.0

Comments

@dougbu
Copy link
Member

dougbu commented Jun 9, 2016 •
edited
Loading

Specifically want to explore more of the JSON serialization conventions now the #4283 fix is in:

  • Dictionary keys should maintain their case.
  • Complex objects with [JsonProperty(PropertyName = "...")] or [JsonProperty(NamingStrategyType = typeof(...))] on properties should be serialized according to those overrides.

Discussed offline and I believe we should aim to get this into 1.0.0.
@dougbu
Copy link
Member Author

dougbu commented Jun 9, 2016

Grew out of a PR discussion. Thanks @JamesNK!

@dougbu dougbu mentioned this issue Jun 9, 2016
Closed
@Eilon Eilon added this to the 1.0.0 milestone Jun 9, 2016
@Eilon Eilon added the 1 - Ready label Jun 9, 2016
dougbu added a commit that referenced this issue Jun 10, 2016
@dougbu
Add tests covering more JSON serialization cases
c30759b 
- #4844
@dougbu dougbu mentioned this issue Jun 10, 2016
Closed
dougbu added a commit that referenced this issue Jun 10, 2016
@dougbu
Add tests covering more JSON serialization cases
68974b2 
- #4844
@dougbu
Copy link
Member Author

dougbu commented Jun 10, 2016

68974b2

@dougbu dougbu closed this as completed Jun 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dougbu dougbu

Labels
3 - Done Add Tests
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@Eilon @dougbu