Skip to content
This repository was archived by the owner on Dec 14, 2018. It is now read-only.

CompositeValueProvider does not match IBindingSourceValueProvider contract #2907

Closed
dougbu opened this issue Aug 4, 2015 · 3 comments
Closed

CompositeValueProvider does not match IBindingSourceValueProvider contract #2907

dougbu opened this issue Aug 4, 2015 · 3 comments
Assignees
@dougbu
Labels
3 - Done bug feature-Model-Binding
Milestone
1.0.0-beta7

Comments

@dougbu
Copy link
Member

dougbu commented Aug 4, 2015

Of the IBindingSourceValueProvider implementations in MVC, all but CompositeValueProvider have a Filter() method that returns null when the requested BindingSource does not match. CompositeValueProvider instead returns an empty CompositeValueProvider.

Also have a little code in CompositeModelBinder and MutableObjectModelBinder that expects the CompositeValueProvider behaviour of all IBindingSourceValueProvider impelmentations. That is, they need to change slightly to handle the expected / contracted null return values from Filter().
@Eilon Eilon added this to the 6.0.0-beta7 milestone Aug 4, 2015
@Eilon
Copy link
Member

Eilon commented Aug 4, 2015

Make 'em match!

@dougbu
Copy link
Member Author

dougbu commented Aug 4, 2015

Teal it is 😈

dougbu added a commit that referenced this issue Aug 6, 2015
@dougbu
Make CompositeValueProvider consistent with `IBindingSourceValuePro…
73b4d15 
…vider` contract

- #2907
- return `null` if `Filter()` finds no matching value provider in collection
- fix lack of defensiveness in model binders' use of `IBindingSourceValueProvider` implementations
- remove test workaround for unusual `CompositeValueProvider` behaviour
@dougbu dougbu mentioned this issue Aug 6, 2015
Closed
dougbu added a commit that referenced this issue Aug 6, 2015
@dougbu
Make CompositeValueProvider consistent with `IBindingSourceValuePro…
4a81377 
…vider` contract

- #2907
- return `null` if `Filter()` finds no matching value provider in collection
- fix lack of defensiveness in model binders' use of `IBindingSourceValueProvider` implementations
- remove test workaround for unusual `CompositeValueProvider` behaviour
@dougbu
Copy link
Member Author

dougbu commented Aug 6, 2015

4a81377

@dougbu dougbu closed this as completed Aug 6, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dougbu dougbu

Labels
3 - Done bug feature-Model-Binding
Projects
None yet
Milestone
1.0.0-beta7
Development

No branches or pull requests
2 participants
@Eilon @dougbu