Skip to content
This repository was archived by the owner on Dec 14, 2018. It is now read-only.

Modify TagHelperOutput.CopyHtmlAttribute to maintain attribute order. #2639

Closed
NTaylorMullen opened this issue Jun 1, 2015 · 1 comment
Closed

Modify TagHelperOutput.CopyHtmlAttribute to maintain attribute order. #2639

NTaylorMullen opened this issue Jun 1, 2015 · 1 comment
Assignees
@NTaylorMullen
Labels
3 - Done enhancement
Milestone
1.0.0-beta8

Comments

@NTaylorMullen
Copy link
Contributor

Once aspnet/Razor#225 is completed attributes will be in-order rather than in a semi-random order. With this change we should ensure that TagHelperOutput.CopyHtmlAttribute re-adds attributes to TagHelperOutput to their "most correct" location.
@danroth27 danroth27 added this to the 6.0.0-beta6 milestone Jun 3, 2015
@Eilon Eilon modified the milestones: 6.0.0-beta7, 6.0.0-beta6 Jun 30, 2015
This was referenced Jul 17, 2015
Closed
Merged
@Eilon Eilon modified the milestones: 6.0.0-beta7, 6.0.0-beta8 Aug 12, 2015
NTaylorMullen added a commit that referenced this issue Aug 17, 2015
@NTaylorMullen
Enable CopyHtmlAttribute to maintain copied attribute order.
aeed1bb 
- Updated implementation to do a best guess at copying an attribute back into `TagHelperOutput.Attributes`.
- Updated existing functional and unit tests to account for maintained attribute order.
- Added a set of complex order based unit tests to validate `CopyHtmlAttribute` properly maintains order.

#2639
@NTaylorMullen NTaylorMullen mentioned this issue Aug 17, 2015
Merged
NTaylorMullen added a commit that referenced this issue Aug 18, 2015
@NTaylorMullen
Enable CopyHtmlAttribute to maintain copied attribute order.
244b69d 
- Updated implementation to do a best guess at copying an attribute back into `TagHelperOutput.Attributes`.
- Updated existing functional and unit tests to account for maintained attribute order.
- Added a set of complex order based unit tests to validate `CopyHtmlAttribute` properly maintains order.

#2639
NTaylorMullen added a commit that referenced this issue Aug 19, 2015
@NTaylorMullen
Enable CopyHtmlAttribute to maintain copied attribute order.
7f1e68d 
- Updated implementation to do a best guess at copying an attribute back into `TagHelperOutput.Attributes`.
- Updated existing functional and unit tests to account for maintained attribute order.
- Added a set of complex order based unit tests to validate `CopyHtmlAttribute` properly maintains order.

#2639
NTaylorMullen added a commit that referenced this issue Aug 19, 2015
@NTaylorMullen
Enable CopyHtmlAttribute to maintain copied attribute order.
f1eefdb 
- Updated implementation to do a best guess at copying an attribute back into `TagHelperOutput.Attributes`.
- Updated existing functional and unit tests to account for maintained attribute order.
- Added a set of complex order based unit tests to validate `CopyHtmlAttribute` properly maintains order.

#2639
@NTaylorMullen
Copy link
Contributor Author

f1eefdb

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NTaylorMullen NTaylorMullen

Labels
3 - Done enhancement
Projects
None yet
Milestone
1.0.0-beta8
Development

No branches or pull requests
3 participants
@Eilon @danroth27 @NTaylorMullen