Change the tag helpers FileVersion property to something clearer

[Eilon]

We have a few tag helpers (Link, Script, and the upcoming Image) that have a FileVersion property that indicates whether to add a "version" to the URL to help with cache busting.

The property name is a bit confusing: it looks like it is a file version, as opposed to saying whether to append a file version.

I recommend changing the property to be AppendVersion or similar because that'll be a lot clearer about what it does.

[danroth27]

@DamianEdwards thoughts?

[DamianEdwards]

Sure

[dpaquette]

Any objection to me tackling this one on the weekend?

[Eilon]

Yeah that would be great. Let's settle on a name. Here are a few ideas:

• AppendFileVersion / AddFileVersion
• AppendVersion / AddVersion
• AppendFileHash / AddFileHash
• AppendHash / AddHash
• CacheBust

I do kind of like my original suggestion of AppendVersion because it's concise and reasonably clear about what it does.

Thoughts?

[danroth27]

I can live with AppendVersion. I also like AddFileVersion.

[dpaquette]

I like AppendVersion

[dougbu]

Is this about just the property name? Note that's irrelevant in every scenario except unit testing. The attribute name (what users see in the Razor source) is currently asp-file-version.

If we're going to change the attribute as well, would the name there be asp-append-version?

[danroth27]

Yup.

[Eilon]

@dougbu yes it's just the property name and yes we'd rename the tag helper attribute name.

Sounds like everyone wants to go with AppendVersion!

[DamianEdwards]

👍

[dougbu]

3fe0490

[Daniel15]

The web app template in Visual Studio still uses asp-file-version, looks like it wasn't updated.

[NTaylorMullen]

/cc @rustd

[Daniel15]

I get a 404 on that link; is it a private repo?

[danroth27]

Yeah, sorry about that. Removing the link to avoid further confusion.