Skip to content
This repository was archived by the owner on Dec 14, 2018. It is now read-only.

Use CRC32 instead of MD5 for hashing the file content. #1800

Closed
yishaigalatzer opened this issue Jan 13, 2015 · 2 comments
Closed

Use CRC32 instead of MD5 for hashing the file content. #1800

yishaigalatzer opened this issue Jan 13, 2015 · 2 comments
Assignees
@pranavkm
Labels
3 - Done enhancement Perf
Milestone
1.0.0-beta4

Comments

@yishaigalatzer
Copy link
Contributor

Part of #1204
@yishaigalatzer yishaigalatzer mentioned this issue Jan 13, 2015
Closed
@yishaigalatzer yishaigalatzer added this to the 6.0.0-rc1 milestone Jan 13, 2015
@yishaigalatzer
Copy link
Contributor Author

@DamianEdwards and @GrabYourPitchforks told me they have something we wrote for SignalR. We should first measure the difference in speed. Another alternative is to start by comparing the first say 0.5KB and only if it is the same compare the rest by chunks, because we want to fail fast.

@GrabYourPitchforks
Copy link
Contributor

Among your options are (a) cloning a stable implementation of String.GetHashCode or (b) cloning SignalR's implementation of SipHash [see https://github.com/SignalR/SignalR/blob/master/src/Microsoft.AspNet.SignalR.Core/Infrastructure/SipHashBasedStringEqualityComparer.cs].

pranavkm added a commit that referenced this issue Jan 29, 2015
@pranavkm
Use CRC32 instead of MD5 for hashing the file content.
0935d78 
Fixes #1800
@pranavkm pranavkm mentioned this issue Jan 29, 2015
Closed
pranavkm added a commit that referenced this issue Jan 29, 2015
@pranavkm
Use CRC32 instead of MD5 for hashing the file content.
e2c1c1f 
Fixes #1800
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pranavkm pranavkm

Labels
3 - Done enhancement Perf
Projects
None yet
Milestone
1.0.0-beta4
Development

No branches or pull requests
3 participants
@pranavkm @yishaigalatzer @GrabYourPitchforks