Skip to content
This repository was archived by the owner on Dec 14, 2018. It is now read-only.

Move CreateSerializer out of the base class of XmlSerializer #1075

Closed
yishaigalatzer opened this issue Aug 28, 2014 · 1 comment
Closed

Move CreateSerializer out of the base class of XmlSerializer #1075

yishaigalatzer opened this issue Aug 28, 2014 · 1 comment
Assignees
@rynowak
Labels
3 - Done enhancement
Milestone
1.0.0-alpha4

Comments

@yishaigalatzer
Copy link
Contributor

The base class doesn't make sense and it returns an object which forces casting up stream.

Remove
@yishaigalatzer yishaigalatzer added this to the 6.0.0-alpha4 milestone Aug 28, 2014
sornaks pushed a commit that referenced this issue Sep 10, 2014
#1075: Move CreateSerializer out of the base class of XmlSerializer.
09046ee 
This is to prevent the casting upstream in CreateSerializer(). Since CanWriteResult() depends on CreateSerializer(), it has also been moved along.
@sornaks sornaks mentioned this issue Sep 10, 2014
Closed
sornaks pushed a commit that referenced this issue Sep 11, 2014
#1075: Move CreateSerializer out of the base class of XmlSerializer.
ca50151 
This is to prevent the casting upstream in CreateSerializer(). Since CanWriteResult() depends on CreateSerializer(), it has also been moved along.
@sornaks
Copy link

sornaks commented Sep 16, 2014

Assigning to @rynowak since he has integrated these changes into his PR - #1119

@sornaks sornaks assigned rynowak and unassigned sornaks Sep 16, 2014
@rynowak rynowak closed this as completed Sep 22, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rynowak rynowak

Labels
3 - Done enhancement
Projects
None yet
Milestone
1.0.0-alpha4
Development

No branches or pull requests
4 participants
@yishaigalatzer @rynowak @danroth27 @sornaks