This repository was archived by the owner on Nov 1, 2018. It is now read-only.
Ensure decimal point in decimal parameters #381
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents integer results when performing arithmetic operations on decimal parameters. For example, consider the following query.
Where
value
is the following in C#.Here is a table illustrating the improved result.
Breaking change
You may encounter a breaking change if you previously saved integral decimal values into a column using version 1.x and try to query for equality in version 2.0.0.
For example, if you previously saved the value
3m
intoDecimalColumn
and try the following query in version 2.0 (where$value
is also3m
) it will return no results.To upgrade your database to be fully compatible with decimal parameters in version 2.0.0, you'll need to use
UPDATE
statements like the following.Note, reading decimal columns with
SqliteDataReader
will yield the same values as before. It's only SQL equality comparisons that are affected.