This repository was archived by the owner on Dec 13, 2018. It is now read-only.
Changing BuildScopeImpl to BuildScope<TState> #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BrennanConroy Can you take this one? |
|
Rebasing then merging |
BrennanConroy
force-pushed
the
lodejard/beginscopeoft
branch
3 times, most recently
from
66a9e2e to
d734603
Compare
BrennanConroy
force-pushed
the
lodejard/beginscopeoft
branch
from
d734603 to
dc66274
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces allocations when none of the registered loggers are tracking scope state. In particular when there are no loggers at all.
Closes #366