Skip to content
This repository was archived by the owner on Dec 13, 2018. It is now read-only.

LoggerFactoryExtension.CreateLogger<T> now returns an ILogger<T> #318

Closed
wants to merge 1 commit into from

Conversation

sunsided
Copy link
Contributor

As proposed in #312, LoggerFactoryExtensions.CreateLogger<T>() now returns an ILogger<T> instead of an ILogger.

In order to achieve this, I moved Logger<T> from Microsoft.Extensions.Logging to Microsoft.Extensions.Logging.Abstractions. I thought about moving LoggerFactoryExtension to Microsoft.Extensions.Logging instead but that seemed to do more harm than good.

@dnfclas
Copy link

dnfclas commented Dec 10, 2015

Hi @sunsided, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@kichalla
Copy link
Member

@lodejard @loudej

@kichalla
Copy link
Member

LGTM

@rynowak can you also take a look?

@rynowak
Copy link
Member

rynowak commented Dec 28, 2015

:shipit:

@kichalla
Copy link
Member

d679c78

Thanks for the contribution! @sunsided

@kichalla kichalla closed this Dec 28, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants