This repository was archived by the owner on Dec 13, 2018. It is now read-only.
Doc comments for debug logger #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -69,7 +96,7 @@ public void Log(LogLevel logLevel, int eventId, object state, Exception exceptio | |||
| { | |||
| return; | |||
| } | |||
|
|
|||
| message = $"{ logLevel }: {message}"; | |||
There was a problem hiding this comment.
You need to remove the extra space before and after logLevel
There was a problem hiding this comment.
Unrelated. Not fixing.
|
It will be nice if you remove the LF in the last line in both DebugLogger.cs and DebugLoggerProvider.cs |
|
Looks decent 😄 |
|
@BrennanConroy @troydai , anyone? |
| @@ -69,7 +81,7 @@ public void Log(LogLevel logLevel, int eventId, object state, Exception exceptio | |||
| { | |||
| return; | |||
| } | |||
|
|
|||
|
Looks good |
victorhurdugaci
force-pushed
the
victorhu/debug-logger-pr
branch
from
2b0e777 to
1915f2f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to the comments here
@DamianEdwards @davidfowl