Skip to content
This repository was archived by the owner on Dec 13, 2018. It is now read-only.

Logger from Type name shouldn't include generic parameters #326

Closed
lodejard opened this issue Dec 28, 2015 · 4 comments
Closed

Logger from Type name shouldn't include generic parameters #326

lodejard opened this issue Dec 28, 2015 · 4 comments
Assignees
@kichalla
Labels
3 - Done bug
Milestone
1.0.0-rc2

Comments

@lodejard
Copy link
Contributor

At the moment I believe an ILogger for MyNamespace.MyClass<AnotherNamespace.AnotherType> will return a logger category name which ends with the <AnotherNamespace.AnotherType>

It shouldn't, really, because the logging configuration decisions should be made only on the MyNamespace.MyClass portion. Especially because systems which do logger configuration inheritance are based on a . delimiter the portion of the name MyClass<AnotherNamespace defeats that convention.
@lodejard
Copy link
Contributor Author

/cc @muratg @Eilon

@muratg muratg added this to the 1.0.0-rc2 milestone Dec 28, 2015
@muratg
Copy link

muratg commented Dec 28, 2015

👍

@Eilon
Copy link
Member

Eilon commented Dec 28, 2015

The poor type beautifier... and all the work that went into... copying existing code from another project 😦

kichalla added a commit that referenced this issue Dec 29, 2015
@kichalla
Fixes #326: Logger from Type name shouldn't include generic parameters
6bc33cd
kichalla added a commit that referenced this issue Dec 29, 2015
@kichalla
Fixes #326: Logger from Type name shouldn't include generic parameters
a9587cc
@kichalla
Copy link
Member

d14f475

@kichalla kichalla reopened this Dec 30, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kichalla kichalla

Labels
3 - Done bug
Projects
None yet
Milestone
1.0.0-rc2
Development

No branches or pull requests
4 participants
@Eilon @lodejard @muratg @kichalla