Skip to content
This repository was archived by the owner on Dec 13, 2018. It is now read-only.

Review ILogger log method #3

Closed
glennc opened this issue Mar 3, 2014 · 4 comments
Closed

Review ILogger log method #3

glennc opened this issue Mar 3, 2014 · 4 comments
Labels
3 - Done bug
Milestone
1.0.0-beta1

Comments

@glennc
Copy link
Member

glennc commented Mar 3, 2014

Need to have severity, object, callback to stringify.

Add bool IsEnabled(severity)
@davidfowl davidfowl modified the milestone: Alpha Apr 16, 2014
@Eilon
Copy link
Member

Eilon commented Sep 30, 2014

Specifically, in this interface: https://github.com/aspnet/Logging/blob/dev/src/Microsoft.Framework.Logging.Interfaces/ILogger.cs

WriteCore needs to be focused on just writing log messages. It should not need to return a bool to indicate success or enabled status. We should add a new IsEnabled method (not sure if it needs the severity param...) to check specifically whether the log is enabled.

@Eilon
Copy link
Member

Eilon commented Sep 30, 2014

@sonjakhan

@davidfowl
Copy link
Member

While we're at it, should we call WriteCore Write/Log?

@sonjakhan sonjakhan self-assigned this Sep 30, 2014
sonjakhan added a commit that referenced this issue Oct 6, 2014
@sonjakhan
Issue #3: Refactoring ILogger
f609635
@sonjakhan sonjakhan added this to the 1.0.0-beta1 milestone Oct 6, 2014
sonjakhan added a commit to aspnet/Routing that referenced this issue Oct 6, 2014
@sonjakhan
Refactoring ILogger, see aspnet/Logging#3
6e83f2a
sonjakhan added a commit to aspnet/Routing that referenced this issue Oct 6, 2014
@sonjakhan
Refactoring ILogger, see aspnet/Logging#3
d208cc5
sonjakhan added a commit that referenced this issue Oct 7, 2014
@sonjakhan
Issue #3: Refactoring ILogger
600539a
sonjakhan added a commit to dotnet/efcore that referenced this issue Oct 7, 2014
@sonjakhan
Updates to ILogger, see aspnet/Logging#3
4098d57
sonjakhan added a commit to aspnet/Mvc that referenced this issue Oct 8, 2014
@sonjakhan
updating ILogger, see aspnet/Logging#3
99e076f
sonjakhan added a commit to dotnet/efcore that referenced this issue Oct 9, 2014
@sonjakhan
Updates to ILogger, see aspnet/Logging#3
1e61763
sonjakhan added a commit to aspnet/Routing that referenced this issue Oct 13, 2014
@sonjakhan
Refactoring ILogger, see aspnet/Logging#3
3353cee
sonjakhan added a commit to aspnet/Routing that referenced this issue Oct 13, 2014
@sonjakhan
Refactoring ILogger, see aspnet/Logging#3
5b516f6
sonjakhan added a commit that referenced this issue Oct 14, 2014
@sonjakhan
Issue #3: Refactoring ILogger
36fdf14
sonjakhan added a commit to aspnet/Routing that referenced this issue Oct 14, 2014
@sonjakhan
Refactoring ILogger, see aspnet/Logging#3
2a8ac59
sonjakhan added a commit to aspnet/Mvc that referenced this issue Oct 14, 2014
@sonjakhan
updating ILogger, see aspnet/Logging#3
0f5bbdf
sonjakhan added a commit to dotnet/efcore that referenced this issue Oct 14, 2014
@sonjakhan
Updates to ILogger, see aspnet/Logging#3
c0aab51
@sonjakhan
Copy link
Contributor

was pushed this morning, coherence-signed has passed :)

sonjakhan added a commit to dotnet/efcore that referenced this issue Oct 15, 2014
@sonjakhan @HaoK
Updates to ILogger, see aspnet/Logging#3
ce0f58a
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
3 - Done bug
Projects
None yet
Milestone
1.0.0-beta1
Development

No branches or pull requests
4 participants
@davidfowl @Eilon @glennc @sonjakhan