Skip to content
This repository was archived by the owner on Dec 13, 2018. It is now read-only.

Code cleanup in logging code #26

Closed
Eilon opened this issue Sep 30, 2014 · 1 comment
Closed

Code cleanup in logging code #26

Eilon opened this issue Sep 30, 2014 · 1 comment

Comments

@Eilon
Copy link
Member

Eilon commented Sep 30, 2014

Some misc code cleanup:

https://github.com/aspnet/Logging/blob/dev/src/Microsoft.Framework.Logging/DiagnosticsScope.cs

  • Rename _disposedValue to _isDisposed

https://github.com/aspnet/Logging/blob/dev/src/Microsoft.Framework.Logging/Logger.cs

  • Mark fields readonly as appropriate (including nested class's fields)
  • Don't initialize fields to default values (e.g. bool to false)
  • Fix names of fields to have leading underscore
  • Rename disposedValue to _isDisposed
  • Change ++i to i++ because reasons

https://github.com/aspnet/Logging/blob/dev/src/Microsoft.Framework.Logging/LoggerFactory.cs

  • Add access modifiers to class members
  • Trim extra newlines at the bottom of the file

https://github.com/aspnet/Logging/blob/dev/test/Microsoft.Framework.Logging.Test/DiagnosticsScopeTests.cs

  • Rename 'DiagnosticsScopeTests' to 'DiagnosticsScopeTest'
@Eilon
Copy link
Member Author

Eilon commented Sep 30, 2014

@sonjakhan

@sonjakhan sonjakhan self-assigned this Sep 30, 2014
sonjakhan added a commit that referenced this issue Oct 1, 2014
sonjakhan added a commit that referenced this issue Oct 2, 2014
@sonjakhan sonjakhan added this to the 1.0.0-beta1 milestone Oct 6, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants