Skip to content
This repository was archived by the owner on Dec 13, 2018. It is now read-only.

TraceType enum should not pretend to be a flags enum (because it's not) #24

Closed
Eilon opened this issue Sep 30, 2014 · 1 comment
Closed

TraceType enum should not pretend to be a flags enum (because it's not) #24

Eilon opened this issue Sep 30, 2014 · 1 comment
Labels
3 - Done bug
Milestone
1.0.0-beta1

Comments

@Eilon
Copy link
Member

Eilon commented Sep 30, 2014

This enum: https://github.com/aspnet/Logging/blob/dev/src/Microsoft.Framework.Logging.Interfaces/TraceType.cs

It uses powers of 2, but is not a flags enum. It should just use 0, 1, 2, 3, etc.
@Eilon
Copy link
Member Author

Eilon commented Sep 30, 2014

@sonjakhan

@sonjakhan sonjakhan self-assigned this Sep 30, 2014
sonjakhan added a commit that referenced this issue Oct 2, 2014
@sonjakhan
#24 fix TraceType enum values to be consecutive
b7380f9 
#24
@sonjakhan sonjakhan mentioned this issue Oct 2, 2014
Closed
sonjakhan added a commit that referenced this issue Oct 2, 2014
@sonjakhan
incorporated feedback for issue #24
a1d27a1
sonjakhan added a commit that referenced this issue Oct 3, 2014
@sonjakhan
fix for #24: changed TraceType enum values to be consecutive
03db3ad
@sonjakhan sonjakhan mentioned this issue Oct 3, 2014
Merged
sonjakhan added a commit that referenced this issue Oct 4, 2014
@sonjakhan
fix for #24: changed TraceType enum values to be consecutive
ba2b9a5
@sonjakhan sonjakhan added the bug label Oct 6, 2014
@davidfowl davidfowl added this to the 1.0.0-beta1 milestone Oct 6, 2014
sonjakhan added a commit that referenced this issue Oct 10, 2014
@sonjakhan
fix for #24: changed TraceType enum values to be consecutive
8f88125
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
3 - Done bug
Projects
None yet
Milestone
1.0.0-beta1
Development

No branches or pull requests
3 participants
@davidfowl @Eilon @sonjakhan