Skip to content
This repository was archived by the owner on Dec 18, 2018. It is now read-only.

[2.1.3] Consistently handle connection aborts #2636

Closed
halter73 opened this issue May 31, 2018 · 4 comments
Closed

[2.1.3] Consistently handle connection aborts #2636

halter73 opened this issue May 31, 2018 · 4 comments
Assignees
Labels
3 - Done cost: S Will take up to 2 days to complete SHP: Approved Shiproom has approved the issue
Milestone

Comments

@halter73
Copy link
Member

We should backport backport of graceful server shutdown fixes which improve functional test reliability, and followup PRs that normalize the exceptions thrown by the libuv and socket transports while providing better logs and error messages.

Here are the dev PRs that should backported to 2.1 release branch:

#2566
#2574
#2547
#2612

@halter73 halter73 added blocked Blocked SHP: Approval pending Shiproom approval is required for the issue labels May 31, 2018
@halter73 halter73 added this to the 2.1.3 milestone May 31, 2018
@halter73 halter73 self-assigned this May 31, 2018
@halter73
Copy link
Member Author

Here are some examples of customer-reported issues or comments filed in the last 30 days that I think this also addresses. Some are closed because they are already fixed in dev:

#2546 (comment)
#2540
#2536 (comment)
#2536 (comment)
#2631

There are even more issues older than 30 days.

@halter73 halter73 added the cost: S Will take up to 2 days to complete label Jun 11, 2018
@muratg muratg added SHP: Approved Shiproom has approved the issue and removed SHP: Approval pending Shiproom approval is required for the issue labels Jun 19, 2018
@muratg
Copy link
Contributor

muratg commented Jun 19, 2018

This is approved for 2.1.3.

@halter73 halter73 added 2 - Working and removed blocked Blocked labels Jun 20, 2018
@Eilon
Copy link
Member

Eilon commented Jul 13, 2018

@halter73 - do you have an update on this patch issue?

@halter73
Copy link
Member Author

The backport was merged into our release/2.1 branch 2 weeks ago with #2619. Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3 - Done cost: S Will take up to 2 days to complete SHP: Approved Shiproom has approved the issue
Projects
None yet
Development

No branches or pull requests

3 participants